-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: remove unused eslintrc #17860
Conversation
7f057c6
to
ca14e21
Compare
Codecov Report
@@ Coverage Diff @@
## master #17860 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1609 1609
Lines 64903 64903
Branches 6866 6866
=======================================
Hits 43535 43535
Misses 19502 19502
Partials 1866 1866
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5aefc35
to
c5716b7
Compare
c5716b7
to
c61aefe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work removing the duplications and lowering the complexity!
* chore: remove unused eslintrc * remove unused lint * add comments * change comments
* chore: remove unused eslintrc * remove unused lint * add comments * change comments
SUMMARY
This PR will simplify the config of
eslint
and speed up the lint stageAfter lint speed
Before lint speed
.eslintrc
in the codebasea) superset-frontend/src/common/components/.eslintrc
b) superset-frontend/src/components/.eslintrc
c) superset-frontend/src/dashboard/.eslintrc
a) superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
b) superset-frontend/src/middleware/asyncEvent.ts
file-loader
, becausefile-loader
has replaced withasset/resource
in PR-17909eslint-import-resolver-webpack
. We have set'import/core-modules'
in.eslintrc.js
for resolver.overrides
settings in.eslintrc.js
a)
files: ['cypress-base/**/*']
b)
files: ['webpack*.js']
c)
files: ['*.stories.jsx', '*.stories.tsx']
d)
files: './packages/generator-superset/**/*.test.*'
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION