-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: Moves the Menu to views/components folder #17897
chore: Moves the Menu to views/components folder #17897
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17897 +/- ##
==========================================
- Coverage 67.10% 67.10% -0.01%
==========================================
Files 1609 1609
Lines 64897 64895 -2
Branches 6866 6866
==========================================
- Hits 43547 43545 -2
Misses 19484 19484
Partials 1866 1866
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
import { Tooltip } from 'src/components/Tooltip'; | ||
import { Link } from 'react-router-dom'; | ||
import { Row, Col, Grid } from 'antd'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up!
* chore: Moves the Menu to views/components folder * Fixes imports
* chore: Moves the Menu to views/components folder * Fixes imports
SUMMARY
Moves the
Menu
to theviews/components
folder. This menu is not generic but the one used by the listing views. The generic menu is currently implemented insrc/common/components/index.tsx
and it will be moved to thecomponents
folder in a follow-up PR.This work is part of SIP-61
TESTING INSTRUCTIONS
1 - Execute all tests
2 - All tests should pass
ADDITIONAL INFORMATION