Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Moves the Menu to views/components folder #17897

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Moves the Menu to the views/components folder. This menu is not generic but the one used by the listing views. The generic menu is currently implemented in src/common/components/index.tsx and it will be moved to the components folder in a follow-up PR.

This work is part of SIP-61

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #17897 (db3f36b) into master (8ebec60) will decrease coverage by 0.00%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17897      +/-   ##
==========================================
- Coverage   67.10%   67.10%   -0.01%     
==========================================
  Files        1609     1609              
  Lines       64897    64895       -2     
  Branches     6866     6866              
==========================================
- Hits        43547    43545       -2     
  Misses      19484    19484              
  Partials     1866     1866              
Flag Coverage Δ
javascript 53.77% <88.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/common/components/index.tsx 100.00% <ø> (ø)
superset-frontend/src/views/App.tsx 0.00% <0.00%> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 62.65% <ø> (ø)
.../src/views/CRUD/data/savedquery/SavedQueryList.tsx 70.22% <ø> (ø)
...t-frontend/src/views/components/LanguagePicker.tsx 100.00% <ø> (ø)
...perset-frontend/src/views/components/MenuRight.tsx 84.00% <ø> (ø)
superset-frontend/src/views/menu.tsx 0.00% <0.00%> (ø)
...perset-frontend/src/views/CRUD/alert/AlertList.tsx 72.95% <100.00%> (ø)
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 90.00% <100.00%> (ø)
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 75.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ebec60...db3f36b. Read the comment docs.

import { Tooltip } from 'src/components/Tooltip';
import { Link } from 'react-router-dom';
import { Row, Col, Grid } from 'antd';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@michael-s-molina michael-s-molina merged commit aa91662 into apache:master Jan 7, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
* chore: Moves the Menu to views/components folder

* Fixes imports
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
* chore: Moves the Menu to views/components folder

* Fixes imports
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants