fix: null dates in table chart #17974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17974 +/- ##
=======================================
Coverage 67.08% 67.08%
=======================================
Files 1611 1611
Lines 64919 64920 +1
Branches 6871 6872 +1
=======================================
+ Hits 43548 43551 +3
+ Misses 19504 19503 -1
+ Partials 1867 1866 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@geido Ephemeral environment spinning up at http://54.187.69.126:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
mistercrunch
added
🏷️ bot
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently, when a date is null and it's in a temporal column, it renders as
1970-01-01instead ofN/A. This PR fixes itBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Test dataset (generated in SQL Lab):
Table chart before fix:
Table chart after fix:
TESTING INSTRUCTIONS
CI, new unit test, create a dataset with a temporal column in dev, add at least one row with null, ensure it renders as N/A
ADDITIONAL INFORMATION
to: @ktmud @graceguo-supercat @michael-s-molina @rusackas