Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: reenable lint for test files #17979

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

reenable lint for test files

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #17979 (9792b12) into master (fecb6d9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17979   +/-   ##
=======================================
  Coverage   67.08%   67.08%           
=======================================
  Files        1611     1611           
  Lines       64919    64929   +10     
  Branches     6871     6872    +1     
=======================================
+ Hits        43548    43556    +8     
- Misses      19504    19506    +2     
  Partials     1867     1867           
Flag Coverage Δ
javascript 53.79% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/dashboard/actions/nativeFilters.ts 39.79% <0.00%> (-6.80%) ⬇️
...rset-frontend/src/components/ReportModal/index.tsx 82.22% <0.00%> (-0.34%) ⬇️
...end/src/components/Datasource/DatasourceEditor.jsx 68.93% <0.00%> (ø)
.../components/Header/HeaderActionsDropdown/index.jsx 71.42% <0.00%> (ø)
superset-frontend/src/reports/actions/reports.js 39.39% <0.00%> (+5.18%) ⬆️
superset-frontend/src/dataMask/reducer.ts 60.00% <0.00%> (+10.00%) ⬆️
...lugins/plugin-chart-table/src/utils/formatValue.ts 70.58% <0.00%> (+14.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecb6d9...9792b12. Read the comment docs.

@@ -180,17 +181,6 @@ module.exports = {
],
'no-only-tests/no-only-tests': 'error',
'max-classes-per-file': 0,
'@typescript-eslint/no-non-null-assertion': 0,
// TODO: disabled temporarily, re-enable after monorepo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@zhaoyongjie zhaoyongjie merged commit d8d47ce into apache:master Jan 11, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
* chore: reenable lint for test files

* fix comments
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
* chore: reenable lint for test files

* fix comments
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants