-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(csv-export): pivot v2 with verbose names #18633
Conversation
15a20d0
to
e53598b
Compare
Codecov Report
@@ Coverage Diff @@
## master #18633 +/- ##
=======================================
Coverage 66.31% 66.32%
=======================================
Files 1595 1595
Lines 62599 62603 +4
Branches 6297 6297
=======================================
+ Hits 41513 41519 +6
+ Misses 19440 19438 -2
Partials 1646 1646
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for the fix!
SUMMARY
When exporting a pivoted CSV for the Pivot v2 chart with columns or metrics that have a verbose name, the export fails. This adds the option of passing the
verbose_map
from the datasource to theget_column_name
andget_metric_name
util functions + adds some missing tests. Note that remapping the column names is usually not needed, hence mapping is optional.TESTING INSTRUCTIONS
ADDITIONAL INFORMATION