-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(embedded): aud claim and type for guest token #18651
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18651 +/- ##
==========================================
+ Coverage 66.29% 66.65% +0.36%
==========================================
Files 1603 1603
Lines 62744 63512 +768
Branches 6320 6320
==========================================
+ Hits 41593 42331 +738
- Misses 19499 19529 +30
Partials 1652 1652
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
raise ValueError("Guest token does not contain an aud claim") | ||
if token.get("aud") != aud: | ||
raise ValueError("Guest token does not match the aud claim") | ||
if token.get("type") != "guest": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls add some tests where the supplied token isn't a "guest" token, and where the aud
doesn't match
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION