-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(embedded): make guest token JWT audience callable or str #18748
feat(embedded): make guest token JWT audience callable or str #18748
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18748 +/- ##
==========================================
- Coverage 66.31% 66.14% -0.17%
==========================================
Files 1620 1620
Lines 63075 63080 +5
Branches 6370 6370
==========================================
- Hits 41827 41725 -102
- Misses 19591 19698 +107
Partials 1657 1657
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - might be easier to impl as a helper method in the SM
GUEST_TOKEN_JWT_AUDIENCE should be set to the domain name of the application that is embedding Superset or the superset Server?. |
SUMMARY
GUEST_TOKEN_JWT_AUDIENCE
as a callable, useful for dynamic guest token audience config.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION