Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(deck.gl): multiple layers map size is shrunk #18939

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

This PR fixed the problem that map will be shrunk when using deck.gl multiple layer chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen.Recording.2022-01-05.at.12.37.59.AM.mov

after

2022-02-25.5.10.18.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [chart viz] map is shrunk in deck.gl multiple layer chart #17940
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie self-requested a review February 25, 2022 09:18
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @stephenLYZ !

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #18939 (2368e8a) into master (5752372) will increase coverage by 0.19%.
The diff coverage is 94.13%.

❗ Current head 2368e8a differs from pull request most recent head bc42f4c. Consider uploading reports for the commit bc42f4c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18939      +/-   ##
==========================================
+ Coverage   66.19%   66.38%   +0.19%     
==========================================
  Files        1633     1640       +7     
  Lines       63210    63514     +304     
  Branches     6409     6418       +9     
==========================================
+ Hits        41839    42164     +325     
+ Misses      19711    19690      -21     
  Partials     1660     1660              
Flag Coverage Δ
javascript 50.99% <51.51%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ins/legacy-preset-chart-deckgl/src/Multi/Multi.jsx 0.00% <0.00%> (ø)
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 56.39% <ø> (ø)
...ard/components/FiltersBadge/DetailsPanel/index.tsx 81.81% <ø> (ø)
.../src/dashboard/components/gridComponents/Chart.jsx 57.60% <ø> (ø)
superset-frontend/src/preamble.ts 0.00% <0.00%> (ø)
...erset-frontend/src/profile/components/fixtures.tsx 100.00% <ø> (ø)
superset-frontend/src/views/components/Menu.tsx 56.41% <ø> (ø)
superset/views/utils.py 82.20% <ø> (ø)
...perset-frontend/src/views/components/MenuRight.tsx 72.13% <40.00%> (-7.87%) ⬇️
superset/connectors/sqla/models.py 90.04% <98.02%> (+1.28%) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5752372...bc42f4c. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit 2cb3635 into apache:master Feb 25, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants