Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

docs: fix sql templating typos #18955

Merged
merged 3 commits into from
Feb 28, 2022
Merged

docs: fix sql templating typos #18955

merged 3 commits into from
Feb 28, 2022

Conversation

garyng
Copy link
Contributor

@garyng garyng commented Feb 27, 2022 •
edited
Loading

SUMMARY

Fixing a few minor typos that I found in the documentation.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@garyng garyng marked this pull request as ready for review February 27, 2022 17:16
villebro
villebro approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @garyng, LGTM!

@zhaoyongjie zhaoyongjie changed the title docs: fix minor typos docs: fix sql templating typos Feb 28, 2022
@zhaoyongjie zhaoyongjie merged commit 4775d39 into apache:master Feb 28, 2022
@garyng garyng deleted the patch-1 branch February 28, 2022 17:49
villebro pushed a commit that referenced this pull request Apr 3, 2022
@garyng @villebro
docs: fix sql templating typos (#18955)
ee3b3ae 
(cherry picked from commit 4775d39)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garyng @villebro @mistercrunch @zhaoyongjie