Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Moves CRUD components to the Datasource component #19032

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Moves CRUD components to the Datasource component. The previous components were children of src but are actually sub-components of the Datasource component.

This work is part of SIP-61

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #19032 (90986c1) into master (3298551) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19032   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files        1641     1641           
  Lines       63475    63475           
  Branches     6443     6443           
=======================================
  Hits        42226    42226           
  Misses      19584    19584           
  Partials     1665     1665           
Flag Coverage Δ
javascript 51.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/components/Datasource/CollectionTable.tsx 80.53% <ø> (ø)
...end/src/components/Datasource/DatasourceEditor.jsx 69.36% <ø> (ø)
...erset-frontend/src/components/Datasource/Field.tsx 78.57% <ø> (ø)
...et-frontend/src/components/Datasource/Fieldset.tsx 100.00% <ø> (ø)
...perset-frontend/src/components/Datasource/utils.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3298551...90986c1. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit 71b8d31 into apache:master Mar 7, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
* chore: Moves CRUD components to the Datasource component

* Fixes imports

* Fixes less import

(cherry picked from commit 71b8d31)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants