fix: time filter should be [start, end) #19166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19166 +/- ##
=======================================
Coverage 66.55% 66.55%
=======================================
Files 1646 1646
Lines 63617 63617
Branches 6471 6471
=======================================
+ Hits 42339 42340 +1
+ Misses 19600 19599 -1
Partials 1678 1678
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
approved these changes
Mar 16, 2022
| @@ -308,7 +308,7 @@ def get_time_filter( | |||
| if start_dttm: | |||
| l.append(col >= self.table.text(self.dttm_sql_literal(start_dttm))) | |||
| if end_dttm: | |||
| l.append(col <= self.table.text(self.dttm_sql_literal(end_dttm))) | |||
| l.append(col < self.table.text(self.dttm_sql_literal(end_dttm))) | |||
There was a problem hiding this comment.
Yikes! Thanks @zhaoyongjie for catching this. This was exactly what SIP-15 was fixing.
|
🏷️ preset:2022.11 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 31, 2022
(cherry picked from commit e4c9a0d)
mistercrunch
added
🏷️ bot
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a regression issue from the remove legacy SIP-15 interim logic/flags.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
SIP_15_*logic/flags. This feature has been in flight for a number of years which is sufficient time for institutions to have upgraded. #18906