-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: API for asset sync #19220
feat: API for asset sync #19220
Conversation
7d8946f
to
aa9df9b
Compare
87106cb
to
7be4580
Compare
Codecov Report
@@ Coverage Diff @@
## master #19220 +/- ##
==========================================
- Coverage 66.76% 66.49% -0.28%
==========================================
Files 1670 1671 +1
Lines 64392 64618 +226
Branches 6499 6504 +5
==========================================
- Hits 42991 42967 -24
- Misses 19718 19967 +249
- Partials 1683 1684 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8b7cabd
to
64625ee
Compare
64625ee
to
0fdf1c8
Compare
03db728
to
e9a39a8
Compare
73e0e57
to
12fb954
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the new API!
* feat: API for asset sync * Add unit tests. * Improve tests * Move files * Add more tests
* feat: API for asset sync * Add unit tests. * Improve tests * Move files * Add more tests (cherry picked from commit b05e7db)
* feat: API for asset sync * Add unit tests. * Improve tests * Move files * Add more tests
SUMMARY
This PR exposes
ExportAssetsCommand
andImportAssetsCommand
via an API, allowing users to synchronize their Superset models to and from source control.This depends on #19217.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
I added unit tests for both API endpoints.
ADDITIONAL INFORMATION