Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore!: remove ROW_LEVEL_SECURITY feature flag (permanently enable) #19230

Merged
merged 10 commits into from
Mar 31, 2022

Conversation

suddjian
Copy link
Member

SUMMARY

One of the changes for 2.0

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Closes [2.0] Remove ROW_LEVEL_SECURITY feature flag (permanently set to true) #18903
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@suddjian suddjian requested a review from john-bodley March 17, 2022 00:38
@suddjian suddjian changed the title !chore: remove ROW_LEVEL_SECURITY feature flag (permanently enable) chore!: remove ROW_LEVEL_SECURITY feature flag (permanently enable) Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #19230 (1edc2e0) into master (6828624) will increase coverage by 14.48%.
The diff coverage is 100.00%.

❗ Current head 1edc2e0 differs from pull request most recent head d9ce900. Consider uploading reports for the commit d9ce900 to get more accurate results

@@             Coverage Diff             @@
##           master   #19230       +/-   ##
===========================================
+ Coverage   52.08%   66.57%   +14.48%     
===========================================
  Files        1676     1675        -1     
  Lines       64120    64082       -38     
  Branches     6519     6519               
===========================================
+ Hits        33399    42662     +9263     
+ Misses      29030    19729     -9301     
  Partials     1691     1691               
Flag Coverage Δ
hive 52.70% <100.00%> (+<0.01%) ⬆️
mysql 81.90% <100.00%> (?)
postgres 81.95% <100.00%> (?)
presto 52.54% <100.00%> (+<0.01%) ⬆️
python 82.38% <100.00%> (+29.41%) ⬆️
sqlite 81.72% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.41% <ø> (+0.33%) ⬆️
superset/initialization/__init__.py 91.28% <ø> (+1.74%) ⬆️
superset/connectors/sqla/models.py 89.30% <100.00%> (+16.50%) ⬆️
superset/connectors/sqla/views.py 91.05% <100.00%> (+5.45%) ⬆️
superset/security/manager.py 94.74% <100.00%> (+33.45%) ⬆️
...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js 0.00% <0.00%> (ø)
...plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx 0.00% <0.00%> (ø)
...ugins/legacy-plugin-chart-calendar/src/Calendar.js 0.00% <0.00%> (ø)
...legacy-plugin-chart-calendar/src/ReactCalendar.jsx 0.00% <0.00%> (ø)
...cy-plugin-chart-calendar/src/vendor/cal-heatmap.js 0.00% <0.00%> (ø)
... and 308 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6828624...d9ce900. Read the comment docs.

@suddjian suddjian requested a review from rusackas March 18, 2022 21:02
Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@suddjian suddjian merged commit ab37706 into apache:master Mar 31, 2022
@villebro villebro added the v2.0 label Apr 1, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…apache#19230)

* permanently turn on rls feature flag

* unused imports

* docs

* docs

* unused import
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0] Remove ROW_LEVEL_SECURITY feature flag (permanently set to true)
5 participants