Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Removes hard-coded colors from legacy-plugin-chart-sankey #19493

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Removes hard-coded colors from legacy-plugin-chart-sankey.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-04-01 at 2 47 05 PM

Screen Shot 2022-04-01 at 2 51 41 PM

TESTING INSTRUCTIONS

Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #19493 (ee1af25) into master (5fed10d) will increase coverage by 0.01%.
The diff coverage is 85.00%.

❗ Current head ee1af25 differs from pull request most recent head 60852fc. Consider uploading reports for the commit 60852fc to get more accurate results

@@            Coverage Diff             @@
##           master   #19493      +/-   ##
==========================================
+ Coverage   66.58%   66.59%   +0.01%     
==========================================
  Files        1677     1678       +1     
  Lines       64238    64243       +5     
  Branches     6538     6539       +1     
==========================================
+ Hits        42773    42785      +12     
+ Misses      19766    19763       -3     
+ Partials     1699     1695       -4     
Flag Coverage Δ
javascript 51.35% <85.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...allel-coordinates/src/ReactParallelCoordinates.jsx 0.00% <0.00%> (ø)
...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/App.jsx 0.00% <ø> (ø)
...frontend/src/SqlLab/components/SouthPane/index.tsx 65.62% <ø> (ø)
...c/SqlLab/components/TemplateParamsEditor/index.tsx 75.00% <ø> (ø)
...set-frontend/src/components/ListViewCard/index.tsx 97.56% <ø> (ø)
superset-frontend/src/views/CRUD/utils.tsx 65.57% <ø> (ø)
...rontend/src/SqlLab/components/QueryTable/index.tsx 68.96% <50.00%> (+0.54%) ⬆️
...-ui-chart-controls/src/components/ColumnOption.tsx 85.71% <100.00%> (ø)
...-ui-chart-controls/src/components/MetricOption.tsx 94.73% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fed10d...60852fc. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 06dee82 into apache:master Apr 7, 2022
@michael-s-molina michael-s-molina added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…che#19493)

* chore: Removes hard-coded colors from legacy-plugin-chart-sankey

* Gets opacity from the theme
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants