Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Update font-sizes in ImportModal #19611

Merged
merged 1 commit into from
Apr 11, 2022
Merged

chore: Update font-sizes in ImportModal #19611

merged 1 commit into from
Apr 11, 2022

Conversation

geido
Copy link
Member

@geido geido commented Apr 8, 2022

SUMMARY

This PR removes hacky usages of font-sizes by replacing them with the exact font-sizes available in the theme config.

BEFORE

importmodal-b4

AFTER

Screen Shot 2022-04-08 at 13 37 48

TESTING INSTRUCTIONS

  1. Go to databases
  2. Import a database
  3. Make sure the font-size in the info text looks balanced

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #19611 (4fdd72f) into master (83c3779) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #19611      +/-   ##
==========================================
+ Coverage   66.63%   66.66%   +0.02%     
==========================================
  Files        1680     1681       +1     
  Lines       64292    64309      +17     
  Branches     6564     6565       +1     
==========================================
+ Hits        42839    42869      +30     
+ Misses      19751    19747       -4     
+ Partials     1702     1693       -9     
Flag Coverage Δ
javascript 51.52% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ImportModal/index.tsx 72.50% <100.00%> (ø)
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 52.08% <0.00%> (-0.30%) ⬇️
...ntend/packages/superset-ui-core/src/color/utils.ts 100.00% <0.00%> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.79% <0.00%> (ø)
...ins/legacy-plugin-chart-partition/src/Partition.js 0.00% <0.00%> (ø)
...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx 0.00% <0.00%> (ø)
...s/legacy-plugin-chart-horizon/src/HorizonChart.jsx 0.00% <0.00%> (ø)
...acy-plugin-chart-paired-t-test/src/PairedTTest.jsx 0.00% <0.00%> (ø)
...rt-parallel-coordinates/src/ParallelCoordinates.js 0.00% <0.00%> (ø)
...allel-coordinates/src/ReactParallelCoordinates.jsx 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c3779...4fdd72f. Read the comment docs.

@geido geido added the global:theming Related to theming Superset label Apr 8, 2022
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 5d418b2 into apache:master Apr 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants