chore(frontend): Spelling

scripts/generate_frontend_ts_tasklist.js

@@ -48,10 +48,10 @@ while (directories.length) {
   // directory.
   const hasTypescriptFiles =
     getFilesByExtensions("./", [".ts", ".tsx"]).length > 0;
-  const hasJavascriptFiles =
+  const hasJavaScriptFiles =
     getFilesByExtensions("./", [".js", ".jsx"]).length > 0;
 
-  if (hasJavascriptFiles) {
+  if (hasJavaScriptFiles) {
     console.log(
       `${"  ".repeat(
         curDirectory.split("/").length - 1

superset-frontend/cypress-base/cypress/integration/dashboard/utils.ts

@@ -347,7 +347,7 @@ export function saveNativeFilterSettings(charts: ChartSpec[]) {
 }
 
 /** ************************************************************************
- * Cancel Native fitler settings
+ * Cancel Native filter settings
  * @returns {None}
  * @summary helper for cancel native filters settings
  ************************************************************************* */

superset-frontend/cypress-base/cypress/support/directories.ts

@@ -84,11 +84,11 @@ export const databasesPage = {
     step: '.helper-top',
     selectDbStepTitle: '.select-db > h4',
     preferredBlockBigQuery: '.preferred > :nth-child(1)',
-    prefferedBlockPostgreSQL: '.preferred > :nth-child(2)',
-    prefferedBlockSnowflake: '.preferred > :nth-child(3)',
-    prefferedBlockMySQL: '.preferred > :nth-child(4)',
-    prefferedBlockAthena: '.preferred > :nth-child(5)',
-    prefferedBlockSheets: '.preferred > :nth-child(6)',
+    preferredBlockPostgreSQL: '.preferred > :nth-child(2)',
+    preferredBlockSnowflake: '.preferred > :nth-child(3)',
+    preferredBlockMySQL: '.preferred > :nth-child(4)',
+    preferredBlockAthena: '.preferred > :nth-child(5)',
+    preferredBlockSheets: '.preferred > :nth-child(6)',
     supportedDatabasesText: '.control-label',
     orChoose: '.available-label',
     dbDropdown: '[class="ant-select-selection-search-input"]',
@@ -590,7 +590,7 @@ export const exploreView = {
       okButton: '.ant-modal-confirm-btns .ant-btn-primary',
     },
   },
-  vizualizationTypeModal: {
+  visualizationTypeModal: {
     vizTypeButton: dataTestLocator('viztype-selector-container'),
   },
 };

superset-frontend/jest.config.js

@@ -26,7 +26,7 @@ module.exports = {
     '\\.svg$': '<rootDir>/spec/__mocks__/svgrMock.tsx',
     '^src/(.*)$': '<rootDir>/src/$1',
     '^spec/(.*)$': '<rootDir>/spec/$1',
-    // mapping plugins of superset-ui to souce code
+    // mapping plugins of superset-ui to source code
     '@superset-ui/(.*)$': '<rootDir>/node_modules/@superset-ui/$1/src',
   },
   testEnvironment: 'jsdom',

superset-frontend/packages/generator-superset/generators/plugin-chart/templates/src/plugin/controlPanel.erb

@@ -30,7 +30,7 @@ const config: ControlPanelConfig = {
    *
    * There are several predefined controls that can be used.
    * Some examples:
-   * - groupby: columns to group by (tranlated to GROUP BY statement)
+   * - groupby: columns to group by (translated to GROUP BY statement)
    * - series: same as groupby, but single selection.
    * - metrics: multiple metrics (translated to aggregate expression)
    * - metric: sane as metrics, but single selection
@@ -91,7 +91,7 @@ const config: ControlPanelConfig = {
    * by the `@superset-ui/core/lib/validator`:
    * - validateNonEmpty: must have at least one value
    * - validateInteger: must be an integer value
-   * - validateNumber: must be an intger or decimal value
+   * - validateNumber: must be an integer or decimal value
    */
 
   // For control input types, see: superset-frontend/src/explore/components/controls/index.js

superset-frontend/packages/superset-ui-chart-controls/src/operators/renameOperator.ts

@@ -21,7 +21,7 @@ import {
   PostProcessingRename,
   ensureIsArray,
   getMetricLabel,
-  ComparisionType,
+  ComparisonType,
   getXAxisLabel,
 } from '@superset-ui/core';
 import { PostProcessingFactory } from './types';
@@ -50,9 +50,9 @@ export const renameOperator: PostProcessingFactory<PostProcessingRename> = (
       (
         isTimeComparison(formData, queryObject) &&
         [
-          ComparisionType.Difference,
-          ComparisionType.Ratio,
-          ComparisionType.Percentage,
+          ComparisonType.Difference,
+          ComparisonType.Ratio,
+          ComparisonType.Percentage,
         ].includes(formData.comparison_type)
       )
     ) &&
@@ -66,7 +66,7 @@ export const renameOperator: PostProcessingFactory<PostProcessingRename> = (
       // we will rename the "metric" from the metricWithOffset label
       // for example: "count__1 year ago" =>	"1 year ago"
       isTimeComparison(formData, queryObject) &&
-      formData.comparison_type === ComparisionType.Values
+      formData.comparison_type === ComparisonType.Values
     ) {
       const metricOffsetMap = getMetricOffsetsMap(formData, queryObject);
       const timeOffsets = ensureIsArray(formData.time_compare);

superset-frontend/packages/superset-ui-chart-controls/src/operators/timeCompareOperator.ts

@@ -17,7 +17,7 @@
  * specific language governing permissions and limitationsxw
  * under the License.
  */
-import { ComparisionType, PostProcessingCompare } from '@superset-ui/core';
+import { ComparisonType, PostProcessingCompare } from '@superset-ui/core';
 import { getMetricOffsetsMap, isTimeComparison } from './utils';
 import { PostProcessingFactory } from './types';
 
@@ -28,7 +28,7 @@ export const timeCompareOperator: PostProcessingFactory<PostProcessingCompare> =
 
     if (
       isTimeComparison(formData, queryObject) &&
-      comparisonType !== ComparisionType.Values
+      comparisonType !== ComparisonType.Values
     ) {
       return {
         operation: 'compare',

superset-frontend/packages/superset-ui-chart-controls/src/operators/utils/isDerivedSeries.ts

@@ -21,7 +21,7 @@ import {
   ensureIsArray,
   JsonObject,
   QueryFormData,
-  ComparisionType,
+  ComparisonType,
 } from '@superset-ui/core';
 import { isString } from 'lodash';
 
@@ -30,7 +30,7 @@ export const isDerivedSeries = (
   formData: QueryFormData,
 ): boolean => {
   const comparisonType = formData.comparison_type;
-  if (comparisonType !== ComparisionType.Values) {
+  if (comparisonType !== ComparisonType.Values) {
     return false;
   }
 

superset-frontend/packages/superset-ui-chart-controls/src/operators/utils/isTimeComparison.ts

@@ -17,7 +17,7 @@
  * specific language governing permissions and limitationsxw
  * under the License.
  */
-import { ComparisionType } from '@superset-ui/core';
+import { ComparisonType } from '@superset-ui/core';
 import { getMetricOffsetsMap } from './getMetricOffsetsMap';
 import { PostProcessingFactory } from '../types';
 
@@ -29,7 +29,7 @@ export const isTimeComparison: PostProcessingFactory<boolean> = (
   const metricOffsetMap = getMetricOffsetsMap(formData, queryObject);
 
   return (
-    Object.values(ComparisionType).includes(comparisonType) &&
+    Object.values(ComparisonType).includes(comparisonType) &&
     metricOffsetMap.size > 0
   );
 };

superset-frontend/packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx

@@ -17,7 +17,7 @@
  * under the License.
  */
 import React from 'react';
-import { t, RollingType, ComparisionType } from '@superset-ui/core';
+import { t, RollingType, ComparisonType } from '@superset-ui/core';
 import { ControlPanelSectionConfig } from '../types';
 import { formatSelectOptions } from '../utils';
 
@@ -137,10 +137,10 @@ export const advancedAnalyticsControls: ControlPanelSectionConfig = {
           label: t('Calculation type'),
           default: 'values',
           choices: [
-            [ComparisionType.Values, t('Actual values')],
-            [ComparisionType.Difference, t('Difference')],
-            [ComparisionType.Percentage, t('Percentage change')],
-            [ComparisionType.Ratio, t('Ratio')],
+            [ComparisonType.Values, t('Actual values')],
+            [ComparisonType.Difference, t('Difference')],
+            [ComparisonType.Percentage, t('Percentage change')],
+            [ComparisonType.Ratio, t('Ratio')],
           ],
           description: t(
             'How to display time shifts: as individual lines; as the ' +

superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/components/ColumnConfigControl/constants.tsx

@@ -149,7 +149,7 @@ export const SHARED_COLUMN_CONFIG_PROPS = {
     label: t('Small number format'),
     description: t(
       'D3 number format for numbers between -1.0 and 1.0, ' +
-        'useful when you want to have different siginificant digits for small and large numbers',
+        'useful when you want to have different significant digits for small and large numbers',
     ),
   },
   d3TimeFormat,

superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/sharedControls.tsx

@@ -40,7 +40,7 @@ import {
   getSequentialSchemeRegistry,
   SequentialScheme,
   legacyValidateInteger,
-  ComparisionType,
+  ComparisonType,
   isAdhocColumn,
   isPhysicalColumn,
   ensureIsArray,
@@ -308,7 +308,7 @@ const y_axis_format: SharedControlConfig<'SelectControl', SelectDefaultOption> =
       option.label.includes(search) || option.value.includes(search),
     mapStateToProps: state => {
       const isPercentage =
-        state.controls?.comparison_type?.value === ComparisionType.Percentage;
+        state.controls?.comparison_type?.value === ComparisonType.Percentage;
       return {
         choices: isPercentage
           ? D3_FORMAT_OPTIONS.filter(option => option[0].includes('%'))

superset-frontend/packages/superset-ui-chart-controls/src/types.ts

@@ -92,7 +92,7 @@ export interface ControlPanelState {
 }
 
 /**
- * The action dispather will call Redux `dispatch` internally and return what's
+ * The action dispatcher will call Redux `dispatch` internally and return what's
  * returned from `dispatch`, which by default is the original or another action.
  */
 export interface ActionDispatcher<
@@ -200,7 +200,7 @@ export type TabOverride = 'data' | 'customize' | boolean;
      tab, or 'customize' if you want it to show up on that tam. Otherwise sections with ALL
      `renderTrigger: true` components will show up on the `Customize` tab.
  * - visibility: a function that uses control panel props to check whether a control should
- *    be visibile.
+ *    be visible.
  */
 export interface BaseControlConfig<
   T extends ControlType = ControlType,

superset-frontend/packages/superset-ui-chart-controls/src/utils/expandControlConfig.tsx

@@ -74,7 +74,7 @@ export function expandControlConfig(
   // {
   //   name: 'metric',
   //   config: {
-  //     type: 'SelectControl' | SelectComonent
+  //     type: 'SelectControl' | SelectComponent
   //   }
   // }
   if ('name' in control && 'config' in control) {

superset-frontend/packages/superset-ui-chart-controls/test/operators/renameOperator.test.ts

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { ComparisionType, QueryObject, SqlaFormData } from '@superset-ui/core';
+import { ComparisonType, QueryObject, SqlaFormData } from '@superset-ui/core';
 import { renameOperator } from '@superset-ui/chart-controls';
 
 const formData: SqlaFormData = {
@@ -74,9 +74,9 @@ test('should skip renameOperator if does not exist x_axis and is_timeseries', ()
 
 test('should skip renameOperator if exists derived metrics', () => {
   [
-    ComparisionType.Difference,
-    ComparisionType.Ratio,
-    ComparisionType.Percentage,
+    ComparisonType.Difference,
+    ComparisonType.Ratio,
+    ComparisonType.Percentage,
   ].forEach(type => {
     expect(
       renameOperator(
@@ -126,7 +126,7 @@ test('should add renameOperator if exist "actual value" time comparison', () =>
       {
         ...formData,
         ...{
-          comparison_type: ComparisionType.Values,
+          comparison_type: ComparisonType.Values,
           time_compare: ['1 year ago', '1 year later'],
         },
       },

superset-frontend/packages/superset-ui-chart-controls/test/operators/rollingWindowOperator.test.ts

@@ -107,8 +107,8 @@ test('rolling_type: sum/mean/std', () => {
 });
 
 test('should append compared metrics when sets time compare type', () => {
-  const comparisionTypes = ['values', 'difference', 'percentage', 'ratio'];
-  comparisionTypes.forEach(cType => {
+  const comparisonTypes = ['values', 'difference', 'percentage', 'ratio'];
+  comparisonTypes.forEach(cType => {
     expect(
       rollingWindowOperator(
         {

superset-frontend/packages/superset-ui-chart-controls/test/operators/timeCompareOperator.test.ts

@@ -90,8 +90,8 @@ test('should skip CompareOperator', () => {
 });
 
 test('should generate difference/percentage/ratio CompareOperator', () => {
-  const comparisionTypes = ['difference', 'percentage', 'ratio'];
-  comparisionTypes.forEach(cType => {
+  const comparisonTypes = ['difference', 'percentage', 'ratio'];
+  comparisonTypes.forEach(cType => {
     expect(
       timeCompareOperator(
         {

superset-frontend/packages/superset-ui-chart-controls/test/operators/utils/isDerivedSeries.test.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 import { isDerivedSeries } from '@superset-ui/chart-controls';
-import { SqlaFormData, ComparisionType } from '@superset-ui/core';
+import { SqlaFormData, ComparisonType } from '@superset-ui/core';
 
 const formData: SqlaFormData = {
   datasource: 'foo',
@@ -31,15 +31,15 @@ const series = {
 
 test('should be false if comparison type is not actual values', () => {
   expect(isDerivedSeries(series, formData)).toEqual(false);
-  Object.keys(ComparisionType)
-    .filter(type => type === ComparisionType.Values)
+  Object.keys(ComparisonType)
+    .filter(type => type === ComparisonType.Values)
     .forEach(type => {
-      const formDataWithComparisionType = {
+      const formDataWithComparisonType = {
         ...formData,
         comparison_type: type,
         time_compare: ['1 month ago'],
       };
-      expect(isDerivedSeries(series, formDataWithComparisionType)).toEqual(
+      expect(isDerivedSeries(series, formDataWithComparisonType)).toEqual(
         false,
       );
     });
@@ -48,7 +48,7 @@ test('should be false if comparison type is not actual values', () => {
 test('should be true if comparison type is values', () => {
   const formDataWithActualTypes = {
     ...formData,
-    comparison_type: ComparisionType.Values,
+    comparison_type: ComparisonType.Values,
     time_compare: ['1 month ago', '1 month later'],
   };
   expect(isDerivedSeries(series, formDataWithActualTypes)).toEqual(true);
@@ -62,7 +62,7 @@ test('should be false if series name does not match time_compare', () => {
   };
   const formDataWithActualTypes = {
     ...formData,
-    comparison_type: ComparisionType.Values,
+    comparison_type: ComparisonType.Values,
     time_compare: ['1 month ago', '1 month later'],
   };
   expect(isDerivedSeries(arbitrary_series, formDataWithActualTypes)).toEqual(
@@ -78,7 +78,7 @@ test('should be false if time compare is not suffix', () => {
   };
   const formDataWithActualTypes = {
     ...formData,
-    comparison_type: ComparisionType.Values,
+    comparison_type: ComparisonType.Values,
     time_compare: ['1 month ago', '1 month later'],
   };
   expect(isDerivedSeries(series, formDataWithActualTypes)).toEqual(false);
@@ -92,7 +92,7 @@ test('should be false if series name invalid', () => {
   };
   const formDataWithActualTypes = {
     ...formData,
-    comparison_type: ComparisionType.Values,
+    comparison_type: ComparisonType.Values,
     time_compare: ['1 month ago', '1 month later'],
   };
   expect(isDerivedSeries(series, formDataWithActualTypes)).toEqual(false);

superset-frontend/packages/superset-ui-core/src/chart/components/SuperChart.tsx

@@ -61,7 +61,7 @@ export type Props = Omit<SuperChartCoreProps, 'chartProps'> &
     FallbackComponent?: React.ComponentType<FallbackPropsWithDimension>;
     /** Event listener for unexpected errors from chart */
     onErrorBoundary?: ErrorBoundaryProps['onError'];
-    /** Prop for form plugins uisng superchart */
+    /** Prop for form plugins using superchart */
     showOverflow?: boolean;
     /** Prop for popovercontainer ref */
     parentRef?: RefObject<any>;

superset-frontend/packages/superset-ui-core/src/math-expression/index.ts

@@ -106,7 +106,7 @@ export function evalExpression(expression: string, value: number): number {
   const subExpressions = String(parsedExpression).split('=');
   parsedExpression = subExpressions[1] ?? subExpressions[0];
   // we can ignore the type requirement on `TOKENS`, as value is always `number`
-  // and doesn't need to consider `number | underfined`.
+  // and doesn't need to consider `number | undefined`.
   // @ts-ignore
   return Number(mexp.eval(parsedExpression, TOKENS, { x: value }));
 }

superset-frontend/packages/superset-ui-core/src/query/buildQueryObject.ts

@@ -103,7 +103,7 @@ export default function buildQueryObject<T extends QueryFormData>(
 
   let queryObject: QueryObject = {
     // fallback `null` to `undefined` so they won't be sent to the backend
-    // (JSON.strinify will ignore `undefined`.)
+    // (JSON.stringify will ignore `undefined`.)
     time_range: time_range || undefined,
     since: since || undefined,
     until: until || undefined,

superset-frontend/packages/superset-ui-core/src/query/normalizeOrderBy.ts

@@ -56,7 +56,7 @@ export default function normalizeOrderBy(
     };
   }
 
-  // todo: Removed `legacy_ordery_by` after refactoring
+  // todo: Removed `legacy_order_by` after refactoring
   if (
     queryObject.legacy_order_by !== undefined &&
     queryObject.legacy_order_by !== null &&