You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show/Hide Password in Database Connection Creation Dynamic Forms
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
Proposed changes:
By default, anything typed in the password field should be masked
User should be able to toggle to see the password and toggle back to hiding the password ONLY WHEN entering the password when CONNECTING a database, not when EDITING one
When editing an existing db connection the password should be masked WITHOUT the option to show the password to prevent unintentionally showing passwords to someone who didn't initially connect the db
See details in comment on show/hide icon and tooltip text
ADDITIONAL INFORMATION
Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
Migration is atomic, supports rollback & is backwards-compatible
Confirm DB migration upgrade and downgrade tested
Runtime estimates and downtime expectations provided
@yousoph Ephemeral environment spinning up at http://35.166.83.249:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.
@yousoph Ephemeral environment spinning up at http://35.88.99.67:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.
…ng db connection (apache#19694)
* fix(db & connection): make to show/hide the password when only creating db connection
* fix(db & connection): make to fix unit test of Database Modal
sadpandajoe
added a commit
to preset-io/superset
that referenced
this pull request
May 13, 2022
…ng db connection (apache#19694)
* fix(db & connection): make to show/hide the password when only creating db connection
* fix(db & connection): make to fix unit test of Database Modal
🏷️ botA label used by `supersetbot` to keep track of which PR where auto-tagged with release labelsPreset-Patchsize/S🚢 2.0.0
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mistercrunch
added
🏷️ bot
SUMMARY
Show/Hide Password in Database Connection Creation Dynamic Forms
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
Proposed changes:
ADDITIONAL INFORMATION