Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(explore): ignore temporary controls in altered pill #19843

Merged

Conversation

villebro
Copy link
Member

SUMMARY

Currently the AlteredSliceTag pill appears when there are changes to url_params in the form data. Since these are not persisted in chart metadata (see #18960), we should ignore temporary control values when comparing old vs new form data. A test is also added to ensure the pill doesn't render when there are changes present in url_params.

AFTER

Now the pill no longer appears when refreshing a chart with a change to url_params:
image

BEFORE

Previously the pill would always appear when refreshing the chart due to explore_form_data and other url params being present in the URL:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #19843 (7bd5ab4) into master (ae38411) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #19843   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files        1692     1692           
  Lines       64802    64802           
  Branches     6657     6657           
=======================================
  Hits        43129    43129           
  Misses      19973    19973           
  Partials     1700     1700           
Flag Coverage Δ
javascript 51.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/AlteredSliceTag/index.jsx 87.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae38411...7bd5ab4. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix.

@villebro villebro merged commit 2dafff1 into apache:master Apr 26, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants