Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(embedded): third party cookies #20019

Merged
merged 5 commits into from
May 11, 2022
Merged

fix(embedded): third party cookies #20019

merged 5 commits into from
May 11, 2022

Conversation

lilykuang
Copy link
Member

SUMMARY

This pr tries to fix Error: An attempt was made to break through the security policy of the user agent. in chrome with block third cookies setting.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang requested a review from suddjian May 10, 2022 23:39
@codecov
Copy link

codecov bot commented May 11, 2022 •
edited
Loading

Codecov Report

Merging #20019 (b9aceda) into master (7b7de95) will increase coverage by 0.02%.
The diff coverage is 67.72%.

❗ Current head b9aceda differs from pull request most recent head f0e1909. Consider uploading reports for the commit f0e1909 to get more accurate results

@@            Coverage Diff             @@
##           master   #20019      +/-   ##
==========================================
+ Coverage   66.33%   66.35%   +0.02%     
==========================================
  Files        1713     1712       -1     
  Lines       64074    64060      -14     
  Branches     6731     6742      +11     
==========================================
+ Hits        42503    42508       +5     
+ Misses      19859    19841      -18     
+ Partials     1712     1711       -1
Flag Coverage Δ
javascript 51.30% <67.30%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ns/plugin-chart-word-cloud/src/chart/WordCloud.tsx 0.00% <0.00%> (ø)
...rc/SqlLab/components/ScheduleQueryButton/index.tsx 20.75% <0.00%> (ø)
superset-frontend/src/components/Select/styles.tsx 81.13% <ø> (ø)
...ntend/src/dashboard/containers/DashboardHeader.jsx 66.66% <ø> (ø)
...nd/src/explore/components/DataTablesPane/index.tsx 71.55% <ø> (ø)
...rc/explore/components/ExploreChartHeader/index.jsx 53.33% <ø> (+10.22%) ⬆️
...ontrols/AnnotationLayerControl/AnnotationLayer.jsx 74.39% <ø> (ø)
...mponents/controls/AnnotationLayerControl/index.jsx 10.16% <0.00%> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx 41.41% <ø> (ø)
superset-frontend/src/reports/actions/reports.js 39.39% <0.00%> (+3.03%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b7de95...f0e1909. Read the comment docs.

@suddjian
Update superset-frontend/packages/superset-ui-core/src/connection/cal…
f0e1909 
…lApi/callApi.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
suddjian
suddjian approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yas

@lilykuang lilykuang merged commit 3e36d4a into apache:master May 11, 2022
@lilykuang lilykuang deleted the fix/third-party-cookie branch May 11, 2022 21:43
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request May 18, 2022
@sadpandajoe
fix(embedded): third party cookies (apache#20019)
624ca43 
* debugging

* logging

* add comment

* remove logging

* Update superset-frontend/packages/superset-ui-core/src/connection/callApi/callApi.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
(cherry picked from commit 3e36d4a)
@sadpandajoe
Copy link
Member

🏷️ preset:2022.19

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@suddjian @philipher29
fix(embedded): third party cookies (apache#20019)
553db25 
* debugging

* logging

* add comment

* remove logging

* Update superset-frontend/packages/superset-ui-core/src/connection/callApi/callApi.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
@frassinier frassinier mentioned this pull request Sep 22, 2022
Closed
3 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@suddjian suddjian suddjian approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilykuang @sadpandajoe @suddjian @mistercrunch