fix(chart & filters): make to padding between textarea and buttons #20026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20026 +/- ##
=======================================
Coverage 66.33% 66.33%
=======================================
Files 1713 1713
Lines 64082 64085 +3
Branches 6734 6734
=======================================
+ Hits 42509 42511 +2
- Misses 19862 19863 +1
Partials 1711 1711
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stephenLYZ
reviewed
May 11, 2022
...rset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsx
Outdated
Show resolved
Hide resolved
|
/testenv up |
|
@stephenLYZ Ephemeral environment spinning up at http://35.167.217.29:8080. Credentials are |
diegomedina248
approved these changes
May 11, 2022
codemaster08240328
approved these changes
May 11, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
…pache#20026) * fix(chart & filters): make to padding between textarea and buttons * fix(chart & filters): make to change static pixel to them.gridUnit * fix(chart & filters): make to fix lint issue
mistercrunch
added
🏷️ bot
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Padding between TextArea and Buttons.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
How to reproduce issues
ADDITIONAL INFORMATION