-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(css): transparent linear gradient not working in safari #20086
fix(css): transparent linear gradient not working in safari #20086
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20086 +/- ##
==========================================
- Coverage 66.37% 66.34% -0.04%
==========================================
Files 1715 1716 +1
Lines 64179 64311 +132
Branches 6753 6811 +58
==========================================
+ Hits 42602 42665 +63
- Misses 19859 19913 +54
- Partials 1718 1733 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/packages/superset-ui-core/src/style/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know we were already using that emotion-rgba lib. Nifty!
…0086) * fix(css): transparent linear gradient not working in safari * use emotion-rgba instead
SUMMARY
This PR fixes the problem that transparent linear gradient not working in safari. refer to https://css-tricks.com/thing-know-gradients-transparent-black/.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
after
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION