-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(docs): custom and built-in event logging class at the same time #20098
chore(docs): custom and built-in event logging class at the same time #20098
Conversation
bfb41e5
to
28a30f2
Compare
Could someone verify and approve? @craig-rueda @dpgaspar @villebro @michael-s-molina @zhaoyongjie |
Thanks for this contribution @wiktor2200. In the interest of keeping the documentation as compact and to-the-point as possible, I'm unsure if we need to document how to extend the Ping @srinify for thoughts on this? |
I totally agree, it's not rocket science to add it, but it's worth to mention that using custom will stop logging to |
Hi @villebro! I've updated this doc file as you suggested. Removed additional part, leaving only notice about running custom classes simultaneously. Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for iterating on this!
…apache#20098) * chore: custom and built-in event logging class at the same time * fix whitespaces * Update Event Logging docs
SUMMARY
There was lack of documentation for using built-in DB based event logger along with custom JSON logger so I've added that.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION