Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: migration revisions from #19532 #20641

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jul 7, 2022

SUMMARY

fix: migration revisions from #19532

Current master CI is broken

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar requested a review from a team as a code owner July 7, 2022 13:45
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #20641 (c3d11ac) into master (7626c31) will increase coverage by 15.51%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #20641       +/-   ##
===========================================
+ Coverage   51.33%   66.84%   +15.51%     
===========================================
  Files        1754     1754               
  Lines       65731    65731               
  Branches     6950     6950               
===========================================
+ Hits        33740    43940    +10200     
+ Misses      30228    20028    -10200     
  Partials     1763     1763               
Flag Coverage Δ
hive 53.79% <ø> (?)
mysql 82.41% <ø> (?)
postgres 82.48% <ø> (?)
presto 53.65% <ø> (?)
python 82.92% <ø> (+32.14%) ⬆️
sqlite 82.27% <ø> (?)
unit 50.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.47% <0.00%> (+0.32%) ⬆️
superset/views/database/views.py 31.36% <0.00%> (+0.90%) ⬆️
superset/initialization/__init__.py 91.66% <0.00%> (+1.04%) ⬆️
superset/tables/models.py 67.53% <0.00%> (+1.29%) ⬆️
superset/charts/schemas.py 99.35% <0.00%> (+1.94%) ⬆️
superset/explore/utils.py 100.00% <0.00%> (+2.12%) ⬆️
superset/extensions/__init__.py 98.82% <0.00%> (+2.35%) ⬆️
superset/databases/commands/exceptions.py 96.92% <0.00%> (+3.07%) ⬆️
superset/queries/schemas.py 100.00% <0.00%> (+3.33%) ⬆️
superset/sql_parse.py 97.07% <0.00%> (+3.50%) ⬆️
... and 305 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7626c31...c3d11ac. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM

@dpgaspar dpgaspar merged commit 4bfa622 into apache:master Jul 7, 2022
@dpgaspar dpgaspar deleted the fix/migration-revision branch July 7, 2022 14:33
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants