Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(plugin-chart-echarts): xAxis of bar chart overflow #20805

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Jul 21, 2022

SUMMARY

When the type of xAxis is value, some scenarios may cause an overflow problem due to it cannot display all x-axis contents. In this case, we treat this as a category.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

image

after

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #20805 (3d55a19) into master (9c7bcfc) will decrease coverage by 0.01%.
The diff coverage is 45.71%.

❗ Current head 3d55a19 differs from pull request most recent head eb2d15d. Consider uploading reports for the commit eb2d15d to get more accurate results

@@            Coverage Diff             @@
##           master   #20805      +/-   ##
==========================================
- Coverage   66.30%   66.29%   -0.02%     
==========================================
  Files        1756     1758       +2     
  Lines       66735    66809      +74     
  Branches     7049     7058       +9     
==========================================
+ Hits        44251    44288      +37     
- Misses      20688    20720      +32     
- Partials     1796     1801       +5     
Flag Coverage Δ
javascript 51.95% <53.96%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...s/legacy-plugin-chart-heatmap/src/controlPanel.tsx 57.14% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 51.08% <0.00%> (-4.87%) ⬇️
...ins/plugin-chart-echarts/src/components/Echart.tsx 0.00% <0.00%> (ø)
...rset-frontend/src/components/Chart/chartReducer.ts 25.00% <0.00%> (ø)
...t-frontend/src/dashboard/actions/dashboardState.js 37.05% <ø> (+0.50%) ⬆️
...rset-frontend/src/dashboard/actions/datasources.ts 0.00% <0.00%> (ø)
...frontend/src/dashboard/components/Header/index.jsx 59.39% <ø> (ø)
...board/components/nativeFilters/FilterBar/index.tsx 60.58% <ø> (ø)
...set-frontend/src/dashboard/containers/Dashboard.ts 0.00% <ø> (ø)
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephenLYZ I don't know if echart can set xaxis to "discrete axis" instead of "continuous variable axis". This problem may be caused by the wrong type of axis.

@stephenLYZ stephenLYZ force-pushed the fix-bar-chart-xAxis branch from 910c5a0 to eb2d15d Compare July 22, 2022 10:12
@zhaoyongjie zhaoyongjie self-requested a review July 23, 2022 06:16
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, test in my local

image

@zhaoyongjie zhaoyongjie merged commit 9bf7ed5 into apache:master Jul 23, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants