Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: unpin snowflake #20948

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Pin is no longer needed since we've upgraded to SQLAlchemy 1.4.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #20948 (2204fd3) into master (ac58582) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20948   +/-   ##
=======================================
  Coverage   66.38%   66.38%           
=======================================
  Files        1766     1766           
  Lines       67225    67225           
  Branches     7135     7135           
=======================================
  Hits        44626    44626           
  Misses      20774    20774           
  Partials     1825     1825           
Flag Coverage Δ
hive 53.20% <ø> (ø)
mysql 81.02% <ø> (ø)
postgres 81.09% <ø> (ø)
presto 53.10% <ø> (ø)
python 81.56% <ø> (ø)
sqlite 79.67% <ø> (ø)
unit 50.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/sql_lab.py 60.52% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@betodealmeida betodealmeida merged commit bce32af into apache:master Aug 3, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants