Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(dashboard): Fix scroll behaviour in DashboardBuilderSidepane #20969

Merged
merged 2 commits into from
Aug 16, 2022
Merged

fix(dashboard): Fix scroll behaviour in DashboardBuilderSidepane #20969

merged 2 commits into from
Aug 16, 2022

Conversation

EugeneTorap
Copy link
Contributor

Fix wrong scroll behaviour in CHARTS tab on DashboardBuilder

BEFORE

Screen.Recording.2022-08-04.at.10.32.11.mov

AFTER

Screen.Recording.2022-08-04.at.10.30.34.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API
    @michael-s-molina @kgabryje @lyndsiWilliams

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #20969 (a913b18) into master (e214e1a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #20969      +/-   ##
==========================================
+ Coverage   66.34%   66.37%   +0.03%     
==========================================
  Files        1767     1767              
  Lines       67312    67271      -41     
  Branches     7144     7147       +3     
==========================================
- Hits        44656    44653       -3     
+ Misses      20828    20790      -38     
  Partials     1828     1828              
Flag Coverage Δ
javascript 52.11% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ashboard/components/BuilderComponentPane/index.tsx 76.47% <100.00%> (-2.48%) ⬇️
superset/views/core.py 75.52% <0.00%> (ø)
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx 0.00% <0.00%> (ø)
...set-frontend/src/components/Select/AsyncSelect.tsx 83.26% <0.00%> (+0.07%) ⬆️
superset-frontend/src/components/Select/Select.tsx 87.16% <0.00%> (+0.08%) ⬆️
superset/common/query_context_processor.py 90.00% <0.00%> (+0.71%) ⬆️
...frontend/src/SqlLab/components/ResultSet/index.tsx 51.70% <0.00%> (+1.00%) ⬆️
superset/models/helpers.py 40.78% <0.00%> (+1.37%) ⬆️
superset/models/sql_lab.py 78.75% <0.00%> (+1.73%) ⬆️
.../src/components/Select/WindowedSelect/windowed.tsx 72.72% <0.00%> (+2.72%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@michael-s-molina michael-s-molina requested a review from geido August 4, 2022 10:36
@EugeneTorap
Copy link
Contributor Author

@michael-s-molina @kgabryje @lyndsiWilliams @hughhhh Can you review it?

@kgabryje
Copy link
Member

/testenv up

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works great! Thank you for fixing that

@kgabryje kgabryje merged commit 6f3a555 into apache:master Aug 16, 2022
@EugeneTorap EugeneTorap deleted the fix/scroll-in-dash-sidepane branch August 16, 2022 17:30
@github-actions
Copy link
Contributor

@kgabryje Ephemeral environment spinning up at http://34.220.145.169:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@kgabryje
Copy link
Member

/testenv down

eschutho pushed a commit that referenced this pull request Sep 20, 2022
Fahrenheit35 pushed a commit to Fahrenheit35/superset that referenced this pull request Nov 11, 2022
@mistercrunch mistercrunch added 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v2.0 v2.0.1 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants