Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: World Map right-click value #21209

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes the value sent to the drill to detail modal when right-clicking on World Map.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-08-26.at.8.49.29.AM.mov
Screen.Recording.2022-08-26.at.8.50.41.AM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina force-pushed the fix-world-map-right-click-value branch from 3025703 to 36fa492 Compare August 26, 2022 16:47
@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #21209 (36fa492) into master (68fa4d2) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #21209   +/-   ##
=======================================
  Coverage   66.36%   66.37%           
=======================================
  Files        1781     1781           
  Lines       67930    67929    -1     
  Branches     7255     7255           
=======================================
  Hits        45085    45085           
+ Misses      20982    20981    -1     
  Partials     1863     1863           
Flag Coverage Δ
javascript 52.27% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit d41f44f into apache:master Aug 26, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants