Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: Fix act errors in ExploreChartHeader test #21402

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

This PR fixes 14 act errors in superset-frontend/src/explore/components/ExploreChartHeader/ExploreChartHeader.test.tsx

TESTING INSTRUCTIONS

  • cd into superset-frontend/src/explore/components/ExploreChartHeader
  • run npm run test superset-frontend/src/explore/components/ExploreChartHeader/ExploreChartHeader.test.tsx
  • Observe that there are no act errors in the console

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lyndsiWilliams lyndsiWilliams changed the title test: Fix act error in ExploreChartHeader test test: Fix act errors in ExploreChartHeader test Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #21402 (3759d33) into master (71459a6) will not change coverage.
The diff coverage is n/a.

❗ Current head 3759d33 differs from pull request most recent head 5110fac. Consider uploading reports for the commit 5110fac to get more accurate results

@@           Coverage Diff           @@
##           master   #21402   +/-   ##
=======================================
  Coverage   66.58%   66.58%           
=======================================
  Files        1791     1791           
  Lines       68559    68559           
  Branches     7319     7319           
=======================================
  Hits        45647    45647           
  Misses      21022    21022           
  Partials     1890     1890           
Flag Coverage Δ
javascript 52.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit d635566 into master Sep 9, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/ExploreChartHeader-act-cleanup branch September 9, 2022 16:27
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants