Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: add deprecated decorator for old SupersetView's #22113

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

dpgaspar
Copy link
Member

SUMMARY

Small refactor that adds a decorator for deprecation warnings for old SupersetViews's API endpoints. DRY.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #22113 (c398cf4) into master (7c6fabb) will decrease coverage by 1.36%.
The diff coverage is 100.00%.

❗ Current head c398cf4 differs from pull request most recent head 0e1f03a. Consider uploading reports for the commit 0e1f03a to get more accurate results

@@            Coverage Diff             @@
##           master   #22113      +/-   ##
==========================================
- Coverage   67.12%   65.76%   -1.37%     
==========================================
  Files        1831     1831              
  Lines       69994    70001       +7     
  Branches     7570     7570              
==========================================
- Hits        46984    46034     -950     
- Misses      21045    22002     +957     
  Partials     1965     1965              
Flag Coverage Δ
hive 52.88% <91.30%> (+0.03%) ⬆️
mysql 78.41% <100.00%> (+0.01%) ⬆️
postgres ?
presto ?
python 78.73% <100.00%> (-2.85%) ⬇️
sqlite 76.94% <100.00%> (+0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/base.py 76.28% <100.00%> (+0.58%) ⬆️
superset/views/core.py 76.09% <100.00%> (+0.15%) ⬆️
superset/tables/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
superset/columns/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
...set/advanced_data_type/plugins/internet_address.py 16.32% <0.00%> (-79.60%) ⬇️
superset/utils/pandas_postprocessing/boxplot.py 20.51% <0.00%> (-79.49%) ⬇️
superset/charts/post_processing.py 11.76% <0.00%> (-77.95%) ⬇️
...perset/advanced_data_type/plugins/internet_port.py 18.75% <0.00%> (-77.09%) ⬇️
superset/utils/pandas_postprocessing/rolling.py 21.87% <0.00%> (-68.75%) ⬇️
...perset/utils/pandas_postprocessing/contribution.py 34.61% <0.00%> (-65.39%) ⬇️
... and 62 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM.

@dpgaspar dpgaspar merged commit ed1f50e into apache:master Nov 14, 2022
@dpgaspar dpgaspar deleted the chore/add-deprecation-decor branch November 14, 2022 13:34
@michael-s-molina
Copy link
Member

Love this! Much cleaner! Thanks @dpgaspar.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants