-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: Localization of Superset pt. 1 #22150
Conversation
@villebro take a look please |
@michael-s-molina could you take a look please? |
Codecov Report
@@ Coverage Diff @@
## master #22150 +/- ##
===========================================
- Coverage 67.10% 55.84% -11.26%
===========================================
Files 1869 1869
Lines 71580 71582 +2
Branches 7806 7806
===========================================
- Hits 48031 39978 -8053
- Misses 21521 29576 +8055
Partials 2028 2028
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Deleting a tab will remove all content within it. You may still | ||
reverse this action with the <b>undo</b> button (cmd + z) until you | ||
save your changes. | ||
{t( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if template literals would make this block a little more legible/parsable. Not a dealbreaker.
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Scatter/Scatter.jsx
Show resolved
Hide resolved
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Polygon/Polygon.jsx
Outdated
Show resolved
Hide resolved
This generally looks good to me! I added a couple clarifying questions. In general, there seems like only one real pint of contention, which is that I'm not sure we want to include the colon-space combo in the translated strings, as the word(s) without the punctuation may provide utility in other settings. For example, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving updates... trying to get CI to pass.
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Arc/Arc.jsx
Outdated
Show resolved
Hide resolved
Approved CI to run. Fingers crossed! Latest changes seem fine too. I'll circle back to merge this if CI passes. If it doesn't, nag me here or on Slack, and we'll sort it out! |
SUMMARY
The localization of some components and especially charts is not complete yet. This PR is the effort to achieve the full localization of Superset. Additionally, it is a real pain to upgrade Superset as one should solve tons of merge conflicts, if they wrapped everything in
t()
and__()
manually, while it is not reflected in the official repo :/ADDITIONAL INFORMATION