fix: Time filter position and click in Horizontal FilterBar

[geido]

SUMMARY

Fixes positioning of the Time filter popover as well as a bug that would close the popover when clicking on the filter from within the Horizontal FilterBar dropdown container.

BEFORE

master.mp4

AFTER

1.-.Sample.dashboard.mp4

TESTING INSTRUCTIONS

See repro steps in the videos

ADDITIONAL INFORMATION

• [] Has associated issue:
• Required feature flags: HORIZONTAL_FILTER_BAR
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #22338 (2ac5f5a) into master (e1ffdb9) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master   #22338      +/-   ##
==========================================
- Coverage   66.85%   66.83%   -0.02%     
==========================================
  Files        1847     1847              
  Lines       70561    70564       +3     
  Branches     7737     7741       +4     
==========================================
- Hits        47174    47163      -11     
- Misses      21380    21394      +14     
  Partials     2007     2007              

Flag	Coverage Δ
hive	52.53% <ø> (ø)
javascript	53.80% <80.00%> (+<0.01%)	⬆️
mysql	?
postgres	78.02% <ø> (ø)
presto	52.42% <ø> (ø)
python	81.19% <ø> (-0.05%)	⬇️
sqlite	76.48% <ø> (ø)
unit	50.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ore/components/controls/DateFilterControl/types.ts	100.00% <ø> (ø)
...d/src/filters/components/Time/TimeFilterPlugin.tsx	0.00% <0.00%> (ø)
...tend/src/filters/components/Time/transformProps.ts	0.00% <ø> (ø)
...rset-frontend/src/filters/components/Time/types.ts	100.00% <ø> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx	55.20% <50.00%> (-0.12%)	⬇️
...ponents/controls/ControlPopover/ControlPopover.tsx	92.72% <100.00%> (+3.63%)	⬆️
superset/common/utils/dataframe_utils.py	90.47% <0.00%> (-4.77%)	⬇️
superset/db_engine_specs/mysql.py	94.04% <0.00%> (-4.77%)	⬇️
superset/models/core.py	89.81% <0.00%> (-0.70%)	⬇️
superset/views/core.py	74.98% <0.00%> (-0.46%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[geido]

Let’s confirm that this isn’t breaking anything new, especially from the original PR that introduced the positioning fixes CC @jinghua-qa

[michael-s-molina]

Tagging @diegomedina248 too.

[michael-s-molina]

LGTM. Can we get @jinghua-qa and @diegomedina248 approvals too?

[diegomedina248]

LGTM

[geido]

/testenv up

[github-actions]

@geido Ephemeral environment spinning up at http://52.12.171.51:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[jinghua-qa]

/testenv up FEATURE_HORIZONTAL_FILTER_BAR

[github-actions]

@jinghua-qa Ephemeral environment spinning up at http://52.41.118.83:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[jinghua-qa]

LGTM

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.