Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: Fix act errors in VizTypeControl test #22424

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

This PR fixes 66 act errors in superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeControl.test.tsx

TESTING INSTRUCTIONS

  • cd into superset-frontend
  • run npm run test superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeControl.test.tsx
  • Observe that there are no act errors in the console

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #22424 (55cb416) into master (bb318cb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22424   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files        1850     1850           
  Lines       70692    70692           
  Branches     7752     7752           
=======================================
  Hits        47294    47294           
  Misses      21382    21382           
  Partials     2016     2016           
Flag Coverage Δ
hive 52.47% <ø> (ø)
javascript 53.85% <ø> (ø)
mysql 77.97% <ø> (ø)
postgres 78.04% <ø> (ø)
presto 52.36% <ø> (ø)
python 81.23% <ø> (ø)
sqlite 76.50% <ø> (ø)
unit 50.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lyndsiWilliams lyndsiWilliams merged commit fa919f3 into master Dec 15, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/fix-act-errors-vizTypeControl branch December 15, 2022 16:27
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants