-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: Use redis 7 on tests and pin on local dev and non-dev #22742
chore: Use redis 7 on tests and pin on local dev and non-dev #22742
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22742 +/- ##
===========================================
- Coverage 67.11% 56.01% -11.10%
===========================================
Files 1869 1869
Lines 71612 71612
Branches 7822 7822
===========================================
- Hits 48059 40113 -7946
- Misses 21526 29472 +7946
Partials 2027 2027
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with note about Postgres bump
image: postgres:10 | ||
image: postgres:14 | ||
container_name: superset_db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention this bump in the title/description, too?
SUMMARY
Pins Redis to major version 7 on local dev and non-dev environments
Updates current tests to run against Redis version 7, current redis 5 has reached EOL: https://endoflife.date/redis
https://docs.redis.com/latest/rs/installing-upgrading/product-lifecycle/
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION