Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Use redis 7 on tests and pin on local dev and non-dev #22742

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jan 16, 2023

SUMMARY

Pins Redis to major version 7 on local dev and non-dev environments

Updates current tests to run against Redis version 7, current redis 5 has reached EOL: https://endoflife.date/redis
https://docs.redis.com/latest/rs/installing-upgrading/product-lifecycle/

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #22742 (350d990) into master (80b3113) will decrease coverage by 11.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #22742       +/-   ##
===========================================
- Coverage   67.11%   56.01%   -11.10%     
===========================================
  Files        1869     1869               
  Lines       71612    71612               
  Branches     7822     7822               
===========================================
- Hits        48059    40113     -7946     
- Misses      21526    29472     +7946     
  Partials     2027     2027               
Flag Coverage Δ
hive 52.59% <ø> (ø)
mysql ?
postgres ?
presto 52.48% <ø> (ø)
python 58.26% <ø> (-23.08%) ⬇️
sqlite ?
unit 51.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/tags/core.py 4.54% <0.00%> (-95.46%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-90.91%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-87.88%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-84.00%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/create.py 30.61% <0.00%> (-69.39%) ⬇️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-69.00%) ⬇️
superset/reports/commands/execute.py 23.33% <0.00%> (-68.67%) ⬇️
... and 289 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar changed the title chore: pin redis on docker (version 7) chore: Use redis 7 on tests and pin on local dev Jan 16, 2023
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with note about Postgres bump

Comment on lines -37 to 38
image: postgres:10
image: postgres:14
container_name: superset_db
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention this bump in the title/description, too?

@dpgaspar dpgaspar changed the title chore: Use redis 7 on tests and pin on local dev chore: Use redis 7 on tests and pin on local dev and non-dev Jan 16, 2023
@dpgaspar dpgaspar merged commit 6d37e66 into apache:master Jan 16, 2023
@dpgaspar dpgaspar deleted the danielgaspar/sc-65405/upgrade-redis-on-local-dev-environment-for branch January 16, 2023 15:45
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants