Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(dashboard): Add remark plugin on markdown #23502

Merged

Conversation

justinpark
Copy link
Member

SUMMARY

Since react-markdown upgrade to latest version, table remark is no longer support in the chart markdown.
This is because the table markdown is an optional in latest react-markdown.
This commit adds the remark-gfm to support the previous support markdowns including table format.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

|Cell A|Cell B|Cell c|
|--|--|--|
|value1|value2|value3|

After:

Screenshot 2023-03-27 at 1 40 14 PM

Before:

Screenshot 2023-03-27 at 1 39 29 PM

TESTING INSTRUCTIONS

Create a dashboard and adds a markdown
type the following markdown

|Cell A|Cell B|Cell c|
|--|--|--|
|value1|value2|value3|

ADDITIONAL INFORMATION

  • Has associated issue: feat: Improves SafeMarkdown HTML sanitization #21895
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark justinpark force-pushed the fix--react-markdown-support-table branch from 6ff78b7 to 3669637 Compare March 27, 2023 21:00
@justinpark justinpark force-pushed the fix--react-markdown-support-table branch from 3669637 to deeadda Compare March 27, 2023 21:07
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #23502 (e04f6df) into master (21578f7) will not change coverage.
The diff coverage is n/a.

❗ Current head e04f6df differs from pull request most recent head 74eb041. Consider uploading reports for the commit 74eb041 to get more accurate results

@@           Coverage Diff           @@
##           master   #23502   +/-   ##
=======================================
  Coverage   67.63%   67.63%           
=======================================
  Files        1910     1910           
  Lines       73746    73746           
  Branches     7987     7987           
=======================================
  Hits        49876    49876           
  Misses      21829    21829           
  Partials     2041     2041           
Flag Coverage Δ
javascript 53.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/superset-ui-core/src/components/SafeMarkdown.tsx 66.66% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@justinpark
Copy link
Member Author

cc: @ktmud @michael-s-molina

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the improvement!

@justinpark justinpark merged commit 439d687 into apache:master Mar 28, 2023
justinpark added a commit to airbnb/superset-fork that referenced this pull request Mar 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants