-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: remove deprecated apis copy_dash, save_dash and add_slices #24353
chore: remove deprecated apis copy_dash, save_dash and add_slices #24353
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24353 +/- ##
==========================================
+ Coverage 67.18% 68.99% +1.81%
==========================================
Files 1903 1903
Lines 74275 74196 -79
Branches 8110 8110
==========================================
+ Hits 49898 51194 +1296
+ Misses 22265 20890 -1375
Partials 2112 2112
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 99 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…into chore/remove-deprecated-apis-5
…into chore/remove-deprecated-apis-5
SUMMARY
Removes deprecated APIs:
/superset/copy_dash/int:dashboard_id/
/superset/save_dash/int:dashboard_id/
/superset/add_slices/int:dashboard_id/
Effort on removing deprecated API from /superset: #24332
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION