Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Add explicit ON DELETE CASCADE for embedded_dashboards #24939

Conversation

john-bodley
Copy link
Member

SUMMARY

Somewhat akin to #24628, this PR ensures explicit ON DELETE CASCADE operations are set for the embedded_dashboards table which means these relationships don't need to be explicitly deleted for non-SQLAlchemy ORM operations.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley requested a review from a team as a code owner August 9, 2023 22:48
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #24939 (acda41f) into master (94c5950) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head acda41f differs from pull request most recent head a0e5621. Consider uploading reports for the commit a0e5621 to get more accurate results

@@            Coverage Diff             @@
##           master   #24939      +/-   ##
==========================================
- Coverage   69.00%   69.00%   -0.01%     
==========================================
  Files        1906     1906              
  Lines       74144    74141       -3     
  Branches     8211     8211              
==========================================
- Hits        51164    51161       -3     
  Misses      20856    20856              
  Partials     2124     2124              
Flag Coverage Δ
hive 54.18% <100.00%> (+<0.01%) ⬆️
mysql 79.21% <100.00%> (-0.01%) ⬇️
postgres 79.31% <100.00%> (-0.01%) ⬇️
presto 54.08% <100.00%> (+<0.01%) ⬆️
python 83.37% <100.00%> (-0.01%) ⬇️
sqlite 77.89% <100.00%> (-0.01%) ⬇️
unit 55.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
superset/daos/dashboard.py 96.71% <ø> (-0.05%) ⬇️
superset/models/embedded_dashboard.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley force-pushed the john-bodley--embedded-dashboards-ondelete-cascade branch from 934f628 to cd27612 Compare August 9, 2023 22:56
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvement @john-bodley!

@michael-s-molina michael-s-molina merged commit 55014bf into apache:master Aug 10, 2023
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 10, 2023
michael-s-molina added a commit that referenced this pull request Aug 10, 2023
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
…#24939)

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants