-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: Add explicit ON DELETE CASCADE for embedded_dashboards #24939
chore: Add explicit ON DELETE CASCADE for embedded_dashboards #24939
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24939 +/- ##
==========================================
- Coverage 69.00% 69.00% -0.01%
==========================================
Files 1906 1906
Lines 74144 74141 -3
Branches 8211 8211
==========================================
- Hits 51164 51161 -3
Misses 20856 20856
Partials 2124 2124
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
934f628
to
cd27612
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the improvement @john-bodley!
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…#24939) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
SUMMARY
Somewhat akin to #24628, this PR ensures explicit ON DELETE CASCADE operations are set for the
embedded_dashboards
table which means these relationships don't need to be explicitly deleted for non-SQLAlchemy ORM operations.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION