fix: finestTemporalGrainFormatter #25618

betodealmeida · 2023-10-11T20:26:33Z

SUMMARY

Fix a small bug in the finestTemporalGrainFormatter function. The column name was being used incorrectly.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2023-10-11T20:34:42Z

Codecov Report

Merging #25618 (1761e5b) into master (f556ef5) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master   #25618      +/-   ##
==========================================
- Coverage   68.99%   68.99%   -0.01%     
==========================================
  Files        1930     1930              
  Lines       75463    75475      +12     
  Branches     8392     8392              
==========================================
+ Hits        52069    52073       +4     
- Misses      21242    21250       +8     
  Partials     2152     2152

Flag	Coverage Δ
hive	`53.69% <ø> (ø)`
javascript	`56.13% <40.00%> (-0.01%)`	⬇️
mysql	`78.32% <ø> (ø)`
postgres	`78.42% <ø> (ø)`
presto	`53.64% <ø> (ø)`
python	`82.88% <ø> (ø)`
sqlite	`77.07% <ø> (ø)`
unit	`55.49% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...c/filters/components/Select/SelectFilterPlugin.tsx	`59.74% <100.00%> (ø)`
...d/src/explore/components/DatasourcePanel/index.tsx	`63.85% <25.00%> (-0.35%)`	⬇️
...et-frontend/src/SqlLab/reducers/getInitialState.ts	`84.31% <80.95%> (+0.31%)`	⬆️
...rset-frontend/src/explore/components/SaveModal.tsx	`39.51% <42.85%> (+0.67%)`	⬆️
superset-frontend/src/hooks/useTabId.ts	`0.00% <0.00%> (ø)`
superset-frontend/src/SqlLab/reducers/sqlLab.js	`48.58% <0.00%> (-0.84%)`	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

justinpark · 2023-10-12T16:53:42Z

@betodealmeida could you add the test spec for this issue in the following PR?

villebro · 2023-10-12T16:56:44Z

superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx

@@ -117,9 +117,9 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
  const labelFormatter = useMemo(
    () =>
      getDataRecordFormatter({
-        timeFormatter: finestTemporalGrainFormatter(data.map(el => el.col)),
+        timeFormatter: finestTemporalGrainFormatter(data.map(el => el[col])),


I wonder if col may sometimes be an object if it's an adhoc column? If so, we may need to do getColumnLabel(col) on it first..

(cherry picked from commit 62bffaf)

* fix: is_select with UNION (apache#25290) (cherry picked from commit bb002d6) * fix: Add explicit ON DELETE CASCADE for dashboard_roles (apache#25320) (cherry picked from commit d54e827) * fix(chart): Supporting custom SQL as temporal x-axis column with filter (apache#25126) Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> * fix: Use RLS clause instead of ID for cache key (apache#25229) (cherry picked from commit fba66c6) * fix: Improve the reliability of alerts & reports (apache#25239) (cherry picked from commit f672d5d) * fix: DashboardRoles cascade operation (apache#25349) (cherry picked from commit a971a28) * fix: datetime with timezone excel export (apache#25318) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit 5ebcd2a) * fix: Workaround for Cypress ECONNRESET error (apache#25399) (cherry picked from commit d76ff39) * fix(sqllab): invalid persisted tab state (apache#25308) (apache#25398) * fix: Rename on_delete parameter to ondelete (apache#25424) (cherry picked from commit 893b45f) * fix: preventing save button from flickering in SQL Lab (apache#25106) (cherry picked from commit 296ff17) * fix: chart import (apache#25425) (cherry picked from commit a4d8f36) * fix: swagger UI CSP error (apache#25368) (cherry picked from commit 1716b9f) * fix: smarter date formatter (apache#25404) (cherry picked from commit f0080f9) * fix(sqllab): invalid start date (apache#25437) * fix(nativeFilters): Speed up native filters by removing unnecessary rerenders (apache#25282) Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> (cherry picked from commit a0eeb4d) * fix(SqlLab): make icon placement even (apache#25372) (cherry picked from commit 11b49a6) * fix: Duplicate items when pasting into Select (apache#25447) (cherry picked from commit 7cf96cd) * fix: update the SQLAlchemy model definition at json column for Log table (apache#25445) (cherry picked from commit e83a76a) * fix(helm chart): set chart appVersion to 3.0.0 (apache#25373) * fix(mysql): handle string typed decimal results (apache#24241) (cherry picked from commit 7eab59a) * fix: Styles not loading because of faulty CSP setting (apache#25468) (cherry picked from commit 0cebffd) * fix(sqllab): error with lazy_gettext for tab titles (apache#25469) (cherry picked from commit ddde178) * fix: Address Mypy issue which is causing CI to fail (apache#25494) (cherry picked from commit 36ed617) * chore: Adds 3.0.1 CHANGELOG * fix: Unable to sync columns when database or dataset name contains `+` (apache#25390) (cherry picked from commit dbe0838) * fix(sqllab): Broken query containing 'children' (apache#25490) (cherry picked from commit b92957e) * chore: Expand error detail on screencapture (apache#25519) (cherry picked from commit ba541e8) * fix: tags permissions error message (apache#25516) (cherry picked from commit 50b0816) * fix: Apply normalization to all dttm columns (apache#25147) (cherry picked from commit 58fcd29) * fix: REST API CSRF exempt list (apache#25590) (cherry picked from commit 549abb5) * fix(RLS): Fix Info Tooltip + Button Alignment on RLS Modal (apache#25400) (cherry picked from commit a6d0e6f) * fix: thubmnails loading - Talisman default config (apache#25486) (cherry picked from commit 52f631a) * fix(Presto): catch DatabaseError when testing Presto views (apache#25559) Co-authored-by: Rui Zhao <zhaorui@dropbox.com> (cherry picked from commit be3714e) * fix(Charts): Set max row limit + removed the option to use an empty row limit value (apache#25579) (cherry picked from commit f556ef5) * fix(window): unavailable localStorage and sessionStorage (apache#25599) * fix: finestTemporalGrainFormatter (apache#25618) (cherry picked from commit 62bffaf) * fix: revert fix(sqllab): Force trino client async execution (apache#24859) (apache#25541) (cherry picked from commit e56e0de) * chore: Updates 3.0.1 CHANGELOG * fix(sqllab): Mistitled for new tab after rename (apache#25523) (cherry picked from commit a520124) * fix(sqllab): template validation error within comments (apache#25626) (cherry picked from commit b370c66) * fix: avoid 500 errors with SQLLAB_BACKEND_PERSISTENCE (apache#25553) (cherry picked from commit 99f79f5) * fix(import): Make sure query context is overwritten for overwriting imports (apache#25493) (cherry picked from commit a0a0d80) * fix: permalink save/overwrites in explore (apache#25112) Co-authored-by: Elizabeth Thompson <eschutho@gmail.com> (cherry picked from commit e58a3ab) * fix(header navlinks): link navlinks to path prefix (apache#25495) (cherry picked from commit 51c56dd) * fix: improve upload ZIP file validation (apache#25658) * fix: warning of nth-child (apache#23638) (cherry picked from commit 16cc089) * fix(dremio): Fixes issue with Dremio SQL generation for Charts with Series Limit (apache#25657) (cherry picked from commit be82657) --------- Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> Co-authored-by: Zef Lin <zef@preset.io> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Jack Fragassi <jfragassi98@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> Co-authored-by: Jack <41238731+fisjac@users.noreply.github.com> Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Stepan <66589759+Always-prog@users.noreply.github.com> Co-authored-by: Corbin Bullard <corbindbullard@gmail.com> Co-authored-by: Gyuil Han <cnabro91@gmail.com> Co-authored-by: Celalettin Calis <celalettin1286@gmail.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: ʈᵃᵢ <tdupreetan@gmail.com> Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> Co-authored-by: mapledan <mapledan829@gmail.com> Co-authored-by: Igor Khrol <khroliz@gmail.com> Co-authored-by: Rui Zhao <105950525+zhaorui2022@users.noreply.github.com> Co-authored-by: Fabien <18534166+frassinier@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: OskarNS <soerensen.oskar@gmail.com>

fix: finestTemporalGrainFormatter

1761e5b

pull-request-size bot added the size/XS label Oct 11, 2023

Antonio-RiveroMartnez approved these changes Oct 11, 2023

View reviewed changes

betodealmeida merged commit 62bffaf into master Oct 11, 2023

villebro reviewed Oct 12, 2023

View reviewed changes

michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Oct 13, 2023

michael-s-molina pushed a commit that referenced this pull request Oct 13, 2023

fix: finestTemporalGrainFormatter (#25618)

c44f1a3

(cherry picked from commit 62bffaf)

jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Oct 13, 2023

fix: finestTemporalGrainFormatter (apache#25618)

1da6b63

(cherry picked from commit 62bffaf)

jinghua-qa added the preset:2023.41 label Oct 13, 2023

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

fix: finestTemporalGrainFormatter (apache#25618)

75d9aa8

mistercrunch added 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024

fix: finestTemporalGrainFormatter (apache#25618)

db8fc9b

mistercrunch deleted the sc_75338 branch March 26, 2024 18:06

vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024

fix: finestTemporalGrainFormatter (apache#25618)

ef46f77

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: finestTemporalGrainFormatter #25618

fix: finestTemporalGrainFormatter #25618

betodealmeida commented Oct 11, 2023

codecov bot commented Oct 11, 2023 •

edited

Loading

justinpark commented Oct 12, 2023

villebro Oct 12, 2023

fix: finestTemporalGrainFormatter #25618

fix: finestTemporalGrainFormatter #25618

Conversation

betodealmeida commented Oct 11, 2023

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Oct 11, 2023 • edited Loading

Codecov Report

justinpark commented Oct 12, 2023

villebro Oct 12, 2023

Choose a reason for hiding this comment

codecov bot commented Oct 11, 2023 •

edited

Loading