Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Removes unused cache cleanup #26648

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Follow-up of #26349 to remove unused cache cleanup functions. Fixes #26349 (comment).

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e19f59) 69.06% compared to head (abe74b8) 69.06%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26648      +/-   ##
==========================================
- Coverage   69.06%   69.06%   -0.01%     
==========================================
  Files        1930     1930              
  Lines       75309    75288      -21     
  Branches     8429     8429              
==========================================
- Hits        52013    51997      -16     
+ Misses      21149    21144       -5     
  Partials     2147     2147              
Flag Coverage Δ
hive 53.57% <ø> (-0.02%) ⬇️
mysql 77.85% <ø> (-0.05%) ⬇️
postgres 77.95% <ø> (-0.05%) ⬇️
presto 53.52% <ø> (-0.02%) ⬇️
python 82.75% <ø> (+<0.01%) ⬆️
sqlite 77.53% <ø> (-0.05%) ⬇️
unit 55.98% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jan 17, 2024
@michael-s-molina michael-s-molina merged commit 9724abf into apache:master Jan 17, 2024
33 checks passed
Muhammed-baban pushed a commit to intellica-tech/reporting-tool that referenced this pull request Jan 19, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants