Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: spell error analagous -> analogous #27930

Closed
wants to merge 3 commits into from

Conversation

zhangymPerson
Copy link

@zhangymPerson zhangymPerson commented Apr 7, 2024

fix(spell): analagous -> analogous

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas
Copy link
Member

rusackas commented Apr 8, 2024

Thank you for the PR. Unfortunately, I believe since some people flip these flags by all sorts of means of automation, this is considered a breaking change, and we'll have to wait until 5.0. I'll put it on that project board, and we can keep this PR open until then (though it might need rebasing at some point).

@rusackas rusackas added risk:breaking-change Issues or PRs that will introduce breaking changes v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch labels Apr 8, 2024
@sfirke
Copy link
Member

sfirke commented Apr 8, 2024

This has bugged me in the past so I'm pleased to see this PR. I agree about waiting until 5.0.

@@ -52,7 +52,7 @@ These features are **finished** but currently being tested. They are usable, but
- PLAYWRIGHT_REPORTS_AND_THUMBNAILS
- RLS_IN_SQLLAB
- SSH_TUNNELING [(docs)](https://superset.apache.org/docs/installation/setup-ssh-tunneling)
- USE_ANALAGOUS_COLORS
- USE_ANALOGOUS_COLORS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this one is actually a breaking change, I would either not touch or you have to add a note in the UPDATING.md file.

My take on it would be to comment "# excuse the typo, but we'd rather not break backward compatibility"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i will add a note in the UPDATING.md file

@rusackas rusackas added the hold! On hold label Apr 8, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.24%. Comparing base (76d897e) to head (1ce8796).
Report is 1297 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27930      +/-   ##
==========================================
+ Coverage   60.48%   70.24%   +9.76%     
==========================================
  Files        1931     1949      +18     
  Lines       76236    77553    +1317     
  Branches     8568     8731     +163     
==========================================
+ Hits        46114    54480    +8366     
+ Misses      28017    20944    -7073     
- Partials     2105     2129      +24     
Flag Coverage Δ
hive 49.12% <ø> (-0.04%) ⬇️
javascript 57.84% <100.00%> (+0.12%) ⬆️
mysql 77.19% <ø> (?)
postgres 77.30% <ø> (?)
presto 53.67% <ø> (-0.13%) ⬇️
python 83.50% <ø> (+20.01%) ⬆️
sqlite 76.75% <ø> (?)
unit 58.97% <ø> (+1.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas
Copy link
Member

rusackas commented Jan 9, 2025

This PR needed a rebase and a few tweaks, so I just opened a new one rather than bothering @zhangymPerson to update things here again. You get full credit for this, thank you for catching and fixing it! I think we can close this one and merge my copycat PR when CI passes, now that the 5.0 breaking window is open.

@rusackas rusackas closed this Jan 9, 2025
@michael-s-molina michael-s-molina removed the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Feb 3, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
packages risk:breaking-change Issues or PRs that will introduce breaking changes size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants