-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: spell error analagous -> analogous #27930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. Unfortunately, I believe since some people flip these flags by all sorts of means of automation, this is considered a breaking change, and we'll have to wait until 5.0. I'll put it on that project board, and we can keep this PR open until then (though it might need rebasing at some point). |
This has bugged me in the past so I'm pleased to see this PR. I agree about waiting until 5.0. |
@@ -52,7 +52,7 @@ These features are **finished** but currently being tested. They are usable, but | |||
- PLAYWRIGHT_REPORTS_AND_THUMBNAILS | |||
- RLS_IN_SQLLAB | |||
- SSH_TUNNELING [(docs)](https://superset.apache.org/docs/installation/setup-ssh-tunneling) | |||
- USE_ANALAGOUS_COLORS | |||
- USE_ANALOGOUS_COLORS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh this one is actually a breaking change, I would either not touch or you have to add a note in the UPDATING.md
file.
My take on it would be to comment "# excuse the typo, but we'd rather not break backward compatibility"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i will add a note in the UPDATING.md
file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27930 +/- ##
==========================================
+ Coverage 60.48% 70.24% +9.76%
==========================================
Files 1931 1949 +18
Lines 76236 77553 +1317
Branches 8568 8731 +163
==========================================
+ Hits 46114 54480 +8366
+ Misses 28017 20944 -7073
- Partials 2105 2129 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR needed a rebase and a few tweaks, so I just opened a new one rather than bothering @zhangymPerson to update things here again. You get full credit for this, thank you for catching and fixing it! I think we can close this one and merge my copycat PR when CI passes, now that the 5.0 breaking window is open. |
fix(spell): analagous -> analogous
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION