Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(ci): adding codecov token #28277

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix(ci): adding codecov token #28277

merged 1 commit into from
Apr 30, 2024

Conversation

rusackas
Copy link
Member

SUMMARY

Codecov token has been added to GitHub secrets. I think this is all that's needed to leverage it, but I'm not highly confident.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas marked this pull request as ready for review April 30, 2024 18:57
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Apr 30, 2024
@michael-s-molina
Copy link
Member

I'm not highly confident

It looks like this should work.

@rusackas rusackas merged commit 3cc8434 into master Apr 30, 2024
28 of 48 checks passed
@rusackas rusackas deleted the fix-codecov branch April 30, 2024 20:23
@rusackas
Copy link
Member Author

@mistercrunch to answer your question about intent here, this was to resolve the ratelimit problem seen in a whole bunch o' PRs, like so:

image

@rusackas
Copy link
Member Author

Also note that I'm adding this new token to the PMC's 1Password vault in case anyone needs it.

@michael-s-molina michael-s-molina added v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels May 1, 2024
michael-s-molina pushed a commit that referenced this pull request May 1, 2024
@rusackas @michael-s-molina
fix(ci): adding codecov token (#28277)
7840afb 
(cherry picked from commit 3cc8434)
michael-s-molina pushed a commit that referenced this pull request May 1, 2024
@rusackas @michael-s-molina
fix(ci): adding codecov token (#28277)
453f747 
(cherry picked from commit 3cc8434)
@michael-s-molina
Copy link
Member

@rusackas It looks like we need this change for all workflows that connect to Codecov such as database tests. It would be better if we can add the token globally.

jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@rusackas @jzhao62
fix(ci): adding codecov token (apache#28277)
4e48439
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 2, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@rusackas
fix(ci): adding codecov token (apache#28277)
bbbef8a
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels github_actions Pull requests that update GitHub Actions code size/XS v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 3.1.3 🍒 4.0.1 🍒 4.0.2 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rusackas @michael-s-molina @mistercrunch