Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor(Avatar): Migrate Avatar to Ant Design 5 #30740

Merged
merged 5 commits into from
Nov 13, 2024
Merged

refactor(Avatar): Migrate Avatar to Ant Design 5 #30740

merged 5 commits into from
Nov 13, 2024

Conversation

msyavuz
Copy link
Contributor

@msyavuz msyavuz commented Oct 29, 2024

SUMMARY

Migrate Avatar to Ant Design 5 while maintaining visual consistency.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
avatar-before
After:
avatar-after

TESTING INSTRUCTIONS

Test if there are visual changes in-app or storybook.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Ant Design 5: Upgrade Avatar component #30726
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@msyavuz msyavuz force-pushed the msyavuz/refactor/migrate-avatar branch from 35b5f93 to 34f4d71 Compare October 30, 2024 11:23
@msyavuz msyavuz marked this pull request as ready for review October 30, 2024 11:46
@dosubot dosubot bot added change:frontend Requires changing the frontend frontend:refactor:antd5 labels Oct 30, 2024
@geido
Copy link
Member

geido commented Oct 30, 2024

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://18.236.160.116:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido
Copy link
Member

geido commented Oct 31, 2024

Thanks for the PR @msyavuz. I noticed that something is off when you have multiple avatars. The number is misaligned and hovering seems also to be broken (the arrow shows as a dark square). This is on Chrome. It does not happen on master.

Screenshot 2024-10-31 at 15 46 03

Screenshot 2024-10-31 at 15 46 13

@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. hold! On hold labels Oct 31, 2024
@msyavuz
Copy link
Contributor Author

msyavuz commented Nov 4, 2024

@geido Issue was importing from antd-v5/lib. I fixed it but we should be careful with other components in the future as well.

@geido geido removed the hold! On hold label Nov 13, 2024
geido
geido approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@geido geido merged commit 6e665c3 into apache:master Nov 13, 2024
34 of 35 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

asher-lab added a commit to asher-lab/superset that referenced this pull request Nov 22, 2024
@asher-lab @michael-s-molina
@sadpandajoe @mistercrunch @msyavuz @geido @villebro @PaoloTerzi @samarsrivastav @rusackas @amotl @LevisNgigi @dependabot @eschutho @theoriginalgri @lodu @betodealmeida @github-actions @actions-user @justinpark @dimbleby @jpchev @lindenh @seiyab
fix(import): Merge apache/master and resolve conflicts (#20)
8b446df 
* fix: Exception handling for SQL Lab views (apache#30897)

* fix: don't show metadata for embedded dashboards (apache#30875)

* feat: add logging durations for screenshot async service (apache#30884)

* refactor(Avatar): Migrate Avatar to Ant Design 5 (apache#30740)

* refactor(input): Migrate Input component to Ant Design 5 (apache#30730)

* fix(empty dashboards): Allow downloading a screenshot of an empty dashboard (apache#30767)

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* chore(ci): add tai and michael to helm owners (apache#30925)

* fix(helm): use submodule on helm release action (apache#30924)

* docs: add Free2Move to INTHEWILD.md (apache#30930)

* fix: blocks UI elements on right side (apache#30886)

Co-authored-by: Evan Rusackas <evan@preset.io>

* chore(deps): Migrate from `crate[sqlalchemy]` to `sqlalchemy-cratedb` (apache#29243)

* chore: update change log, UPDATING.md and bug-report.yml for 4.1 release (apache#30915)

* chore(docs): Update list of supported databases to include CrateDB (apache#30946)

* feat(trino,presto): add missing time grains (apache#30926)

* fix(Dashboard): Exclude edit param in async screenshot (apache#30962)

* fix(Card): Use correct class names for Ant Design 5 Card component (apache#30964)

* chore(Accessibility): Fix accessibility for 'Show x entries' dropdown in tables (apache#30818)

* build(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /superset-frontend/cypress-base (apache#30969)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(release validation): scripts now support RSA and EDDSA keys. (apache#30967)

* build(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /docs (apache#30970)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: add performance information to tooltip (apache#30948)

* fix(helm-chart): Fix broken PodDisruptionBudget due to introduction of extraLabels. (apache#30966)

* chore(helm): bumping app version to 4.1.1 in helm chart (apache#30918)

* chore: add unit tests for `is_mutating()` (apache#31021)

* chore(🦾): bump python numexpr 2.10.0 -> 2.10.1 (apache#31006)

Co-authored-by: GitHub Action <action@github.com>

* chore(🦾): bump python cffi 1.16.0 -> 1.17.1 (apache#31002)

Co-authored-by: GitHub Action <action@github.com>

* chore(🦾): bump python flask-babel subpackage(s) (apache#31000)

Co-authored-by: GitHub Action <action@github.com>

* fix(Dashboard): Retain colors when color scheme not set (apache#30646)

* fix(explore): verified props is not updated (apache#31008)

* chore: publish wheels (apache#30981)

* docs: Embedded sdk (apache#30972)

* fix(imports): import query_context for imports with charts (apache#30887)

* docs: Update doc about CSV upload (apache#30867)

Co-authored-by: Evan Rusackas <evan@preset.io>

* chore(🦾): bump python cattrs 23.2.3 -> 24.1.2 (apache#30998)

Co-authored-by: GitHub Action <action@github.com>

* fix(dataset): use sqlglot for DML check (apache#31024)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Joe Li <joe@preset.io>
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
Co-authored-by: Mehmet Salih Yavuz <salih.yavuz@proton.me>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Paolo Terzi <PaoloTerzi@users.noreply.github.com>
Co-authored-by: Sukuna <90980311+samarsrivastav@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Andreas Motl <andreas.motl@elmyra.de>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Levis Mbote <111055098+LevisNgigi@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Christoph Keller <github@christophkeller.cc>
Co-authored-by: lodu <48859312+lodu@users.noreply.github.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
Co-authored-by: David Hotham <david.hotham@microsoft.com>
Co-authored-by: Giampaolo Capelli <giampaolo.capelli@gmail.com>
Co-authored-by: Linden <zairrow@gmail.com>
Co-authored-by: Seiya <20365512+seiyab@users.noreply.github.com>
Co-authored-by: Asher Manangan <amanangan@powercosts.com>
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
@msyavuz @nyohasstium
refactor(Avatar): Migrate Avatar to Ant Design 5 (apache#30740)
20d99d9
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
@msyavuz @sadpandajoe
refactor(Avatar): Migrate Avatar to Ant Design 5 (#30740)
207ec95 
(cherry picked from commit 6e665c3)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@geido geido geido approved these changes

@rusackas rusackas Awaiting requested review from rusackas

Assignees
No one assigned
Labels
change:frontend Requires changing the frontend frontend:refactor:antd5 preset:bounty Issues that have been selected by Preset and have a bounty attached. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ant Design 5: Upgrade Avatar component
3 participants
@msyavuz @geido @michael-s-molina