Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

try to unbreak the javascript build #3177

Closed
wants to merge 3 commits into from
Closed

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Jul 25, 2017

Still fails but later. Haven't checked the mapbox visualization though.

Current errors:

ERROR in dashboard.f423afa6c51d3cee7061.entry.js from UglifyJs

Unexpected token: name (Coordinate) [dashboard.f423afa6c51d3cee7061.entry.js:139050,6]

ERROR in explore.a49024d98f20924ba2b6.entry.js from UglifyJs

Unexpected token: name (Coordinate) [explore.a49024d98f20924ba2b6.entry.js:137502,6]

@coveralls
Copy link

coveralls commented Jul 25, 2017

Coverage Status

Coverage remained the same at 69.175% when pulling e70a145 on xrmx:bumpmapbox into 40d9e15 on apache:master.

@mistercrunch
Copy link
Member

Yeah I got about this far too :(

From what I understand UglifyJS chokes on ES6 code. I'm going to try other things today too. Those libs have been a huge amount of problem, I spent 4+ hours on this and it's driving me completely insane.

@xrmx
Copy link
Contributor Author

xrmx commented Jul 25, 2017

@mistercrunch something along these lines maybe? joeeames/WebpackFundamentalsCourse#3 (comment)

@xrmx
Copy link
Contributor Author

xrmx commented Jul 25, 2017

@mistercrunch it builds locally, i haven't run it and my knowledge of webpack is close to null. Please give it a try :)

@xrmx xrmx changed the title WIP: try to unbreak the javascript build try to unbreak the javascript build Jul 25, 2017
@mistercrunch
Copy link
Member

Oh I was working on that here too:
#3179

@xrmx
Copy link
Contributor Author

xrmx commented Jul 25, 2017

@mistercrunch yours look cleaner :)

@xrmx
Copy link
Contributor Author

xrmx commented Jul 25, 2017

Closing in favour of #3179

@xrmx xrmx closed this Jul 25, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants