Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(List Roles): Migrate FAB view to React #32432

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EnxDev
Copy link
Contributor

@EnxDev EnxDev commented Feb 28, 2025

SUMMARY

Migrate List Roles FAB view to React

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • Before
    before
  • After
    after

TESTING INSTRUCTIONS

  1. Add in your superset_config.py the following lines:
FAB_ADD_SECURITY_API = True
FAB_API_MAX_PAGE_SIZE = -1
  1. Run superset init
  2. Go to settings on the frontend and click on Roles

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Feb 28, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@EnxDev EnxDev added the frontend:refactor Related to refactoring the frontend label Feb 28, 2025
@rusackas
Copy link
Member

rusackas commented Mar 3, 2025

Thank you! I can't wait to see the last of these disappear :D

@michael-s-molina
Copy link
Member

Hi @EnxDev. Thanks for working on this! Let me know when it's ready for review as it's still in draft. Regarding this:

FAB_ADD_SECURITY_API = True
FAB_API_MAX_PAGE_SIZE = -1
Run superset init

It would probably require instructions on UPDATING.md.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
frontend:refactor Related to refactoring the frontend size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants