[bugfix] Fix the arguement order for security function #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4745 +/- ##
=======================================
Coverage 72.38% 72.38%
=======================================
Files 205 205
Lines 15374 15374
Branches 1182 1182
=======================================
Hits 11128 11128
Misses 4243 4243
Partials 3 3
Continue to review full report at Codecov.
|
|
Opportunity to add a test? |
|
I'm wondering if the perms are reversed here somehow, which would make this a backward incompatible change... |
feng-tao
force-pushed
the
tfeng_fix_security
branch
from
a75d56e to
e0dda3c
Compare
|
@xrmx, I could add a test if it is an issue. I hope I am not misunderstand the code... |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bug fix: the perm and view_menu seems to be in the wrong order.
cc @mistercrunch @hughhhh