-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: import/export dashboards via cli #6061
feat: import/export dashboards via cli #6061
Conversation
Import is a wrapper around exist functionality so we can go ahead without a test or mock the actual db operation using https://docs.python.org/3/library/unittest.mock.html And validate the wrapper operations only.
@arpit-agarwal Is this rebased on top of current master? |
@kristw Yes However I see it is behind by 1 commit now due to latest commit of @graceguo-supercat . |
I am not sure why this is failing for postgres when exactly same test works for other db. I think it is best to mock the db operations in this test as this code is written on top of existing functionality that is well tested. I am removing tests for now and will raise a new PR with only tests. let me know what you guys think? |
Codecov Report
@@ Coverage Diff @@
## master #6061 +/- ##
==========================================
- Coverage 77.81% 77.59% -0.23%
==========================================
Files 46 47 +1
Lines 9446 9496 +50
==========================================
+ Hits 7350 7368 +18
- Misses 2096 2128 +32
Continue to review full report at Codecov.
|
here is failed build, just for reference in the future: if you follow the stack trace, it goes from I am ok to merge this PR. but when you add unit test in new PR, please pay attention to this scenario. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @graceguo-supercat . I am not sure why they will differ unless some other parallel execution modif the slices transitively |
* feat: import/export dashboards via cli * style: fixed lint error * test: added test for import and export util * test: removing import test as it is causing integrity issues Import is a wrapper around exist functionality so we can go ahead without a test or mock the actual db operation using https://docs.python.org/3/library/unittest.mock.html And validate the wrapper operations only. * test: remove test data file * test: removed usage of reserved keyword id * Fix: remove test that is causing unintended impact
Hello Just wanted to know if this feature has already been released ? if so then in which version of superset ? Thanks a lot. Keep doing the great work :) Cheers, |
This is released in 0.28 |
* feat: import/export dashboards via cli * style: fixed lint error * test: added test for import and export util * test: removing import test as it is causing integrity issues Import is a wrapper around exist functionality so we can go ahead without a test or mock the actual db operation using https://docs.python.org/3/library/unittest.mock.html And validate the wrapper operations only. * test: remove test data file * test: removed usage of reserved keyword id * Fix: remove test that is causing unintended impact
Hi everyone , I need exported dashboards to be imported to another environment from command line to deploy dashboards on DTAP street. Is it possible to see an implementation of this feature? Somehow I could not find it, or maybe I could not understand how to use it. |
Hello All, |
Guess I am answering my own question: Export dashboards from containerized install of SuperSet:-- Login to docker container running superset app: -- Export dashboards: -- Copy the dashboard to localhost
|
This PR will add back changes of #5991 that were reverted by #6035. This PR will close #5821
The travis configuration changes resolved the postgres test stuck issue
@graceguo-supercat We can attach details of travis change as well for future reference.