Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Redirect to druid datasource page when the user wants to add slice. Also, provide a link to the table page #625

Merged
merged 1 commit into from
Jun 15, 2016

Conversation

x4base
Copy link
Contributor

@x4base x4base commented Jun 15, 2016

I don't know now this project focus more on druid datasources or tables. Because in the beginning this project was mainly for Druid, I think it makes sense to redirect to the datasource page by default.
At least we should provide a link like one in this pull request, otherwise it's confusing when a user wants to create a Druid slice but ends up being redirected to a table page.

@coveralls
Copy link

coveralls commented Jun 15, 2016

Coverage Status

Coverage remained the same at 81.962% when pulling d21df6c on x4base:add_druid_slice_by_default into a117498 on airbnb:master.

@mistercrunch mistercrunch merged commit ea8a7ec into apache:master Jun 15, 2016
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0 labels Feb 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants