Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

THRIFT-5343: TTlsSocketTransport does not resolve IPv4 addresses or validate hostnames correctly #2322

Closed
wants to merge 1 commit into from

Conversation

penenin
Copy link
Contributor

@penenin penenin commented Feb 3, 2021

  1. Use the first entry in the address list like TSocketTransport. No need to try to create another IPAddress object.
  2. Save the host name if provided and use that when calling AuthenticateAsClientAsync().
  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G Jens-G self-requested a review February 4, 2021 08:05
@Jens-G Jens-G closed this in 55016bf Feb 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant