Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[TIKA-3381] Lock down the Tika environment in tika-helm #2

Merged
merged 4 commits into from
May 3, 2021
Merged

[TIKA-3381] Lock down the Tika environment in tika-helm #2

merged 4 commits into from
May 3, 2021

Conversation

philipsoutham
Copy link
Contributor

Dropping all kernel capabilities and not running as root user. This starts and seems to work loading the default page, but I would like to have a full test suite to make sure it doesn't break under the various parsing modes to be sure.

@lewismc lewismc changed the title Locking down the Tika environment [TIKA-3381] Lock down the Tika environment in tika-helm May 3, 2021
@lewismc
Copy link
Member

lewismc commented May 3, 2021

Thanks @philipsoutham I am testing using k3d and on our test K8s deployment. Will report back here shortly.

Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @philipsoutham any thoughts on my commentary?

Chart.yaml Outdated
@@ -19,7 +19,7 @@
---
apiVersion: v2
name: tika
version: "latest-full"
version: "1.25"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most recent tika-docker version is 1.26.
I am kinda torn between this usage of both latest and -full.

I don't really like it but I am unsure as to how we should distinguish the vanilla tika-server package within the tika-docker artifact. My goal for tika-helm was simply for the Chart to mimic tika-docker versioning. Any thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewismc, OK I can change that, I just put 1.25 as a WAG because according to the helm spec (https://helm.sh/docs/topics/charts/#the-chartyaml-file) it needs a SemVer 2 version (https://semver.org/) so the latest-full value for version was preventing helm from deploying. I'm not all that familiar with helm so I'm not sure what the best way to parameterize that for automation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... neither am I if I am honest ...!

@agravar
Copy link

agravar commented May 3, 2021

Successfully deployed to our k8s cluster.

tika-helm % helm version  
version.BuildInfo{Version:"v3.1.2", GitCommit:"d878d4d45863e42fd5cff6743294a11d28a9abce", GitTreeState:"clean", GoVersion:"go1.13.8"}
tika-helm % kubectl version
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.3", GitCommit:"a4529464e4629c21224b3d52edfe0ea91b072862", GitTreeState:"clean", BuildDate:"2018-09-09T18:02:47Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.5-dirty", GitCommit:"753b2dbc622f5cc417845f0ff8a77f539a4213ea", GitTreeState:"dirty", BuildDate:"2018-12-03T17:48:52Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}

@lewismc lewismc merged commit ee1be73 into apache:main May 3, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants