Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Go version to 1.22.5 #8034

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Update Go version to 1.22.5 #8034

merged 2 commits into from
Jul 3, 2024

Conversation

asf-ci-trafficcontrol
Copy link
Contributor

What does this PR (Pull Request) do?

This PR makes the Go components of Traffic Control build using Go version 1.22.5 and updates the golang.org/x/ dependencies.

See the Go 1.22.5 release notes:

go1.22.5 (released 2024-07-02) includes security fixes to the net/http package, as well as bug fixes to the compiler, cgo, the go command, the linker, the runtime, and the crypto/tls, go/types, net, net/http, and os/exec packages. See the Go 1.22.5 milestone on our issue tracker for details.

Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)
  • Traffic Control Health Client (tc-health-client)
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Stats
  • Grove
  • CDN in a Box - Enroller
  • CI tests for Go components
  • Build system - Go version in builder images

What is the best way to verify this PR?

Run unit tests and API tests. Since this is only a patch-level version update, the only changes were bugfixes. Breaking changes would be unexpected.

The following criteria are ALL met by this PR

  • Existing tests are sufficient, no additional tests necessary
  • The documentation only mentions the major Go version, no documentation updates necessary.
  • The changelog already mentions updating to Go 1.22, no additional changelog message necessary.
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Copy link
Contributor

@kdamichie kdamichie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zrhoffman zrhoffman merged commit 0b21b43 into master Jul 3, 2024
68 of 69 checks passed
@zrhoffman zrhoffman deleted the go-1.22.5 branch July 3, 2024 16:35
ntheanh201 added a commit to ntheanh201/trafficcontrol that referenced this pull request Jul 19, 2024
* Update Go version to 1.22.5

* Update some images to Rocky Linux 8

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>
zrhoffman added a commit to zrhoffman/trafficcontrol that referenced this pull request Jul 22, 2024
* fix ciab-build

* fix yumserver Dockerfile

* Update Go version to 1.22.5 (apache#8034)

* Update Go version to 1.22.5

* Update some images to Rocky Linux 8

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>
zrhoffman added a commit to zrhoffman/trafficcontrol that referenced this pull request Jul 22, 2024
* fix ciab-build

* fix yumserver Dockerfile

* Update Go version to 1.22.5 (apache#8034)

* Update Go version to 1.22.5

* Update some images to Rocky Linux 8

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>
zrhoffman added a commit to zrhoffman/trafficcontrol that referenced this pull request Aug 15, 2024
* Update Go version to 1.22.5

* Update some images to Rocky Linux 8

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>
zrhoffman added a commit to zrhoffman/trafficcontrol that referenced this pull request Aug 16, 2024
* fix ciab-build

* fix yumserver Dockerfile

* Update Go version to 1.22.5 (apache#8034)

* Update Go version to 1.22.5

* Update some images to Rocky Linux 8

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>
zrhoffman added a commit that referenced this pull request Aug 16, 2024
…7980)

* Store Apache Traffic Server logs in /var/log/trafficserver

* Store Grove logs in /var/log/trafficserver

* chore: change ATS traffic.out folder to /var/log/trafficserver (#122)

* chore: change ATS traffic.out folder to /var/log/trafficserver

* chore: add license

* fix ciab-build (#125)

* fix ciab-build

* fix yumserver Dockerfile

* Update Go version to 1.22.5 (#8034)

* Update Go version to 1.22.5

* Update some images to Rocky Linux 8

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>

---------

Co-authored-by: The Anh Nguyen <ntheanh201@gmail.com>
Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
@zrhoffman zrhoffman mentioned this pull request Sep 27, 2024
4 tasks
rimashah25 pushed a commit to rimashah25/trafficcontrol that referenced this pull request Sep 27, 2024
* Update Go version to 1.22.5

* Update some images to Rocky Linux 8

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>

(cherry picked from commit 0b21b43)
rimashah25 pushed a commit to rimashah25/trafficcontrol that referenced this pull request Sep 27, 2024
* Update Go version to 1.22.5

* Update some images to Rocky Linux 8

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>

(cherry picked from commit 0b21b43)
zrhoffman added a commit that referenced this pull request Sep 27, 2024
* Updated version

* Updated changelog

* Use `docker compose` plugin (#8056)

* docker-compose -> docker compose

Excludes Dockerfile-tsb and the vendor directory.

    sed -i 's/docker-compose /docker compose /g' $(git grep -l 'docker-compose ')
    pattern="$(<<'PATTERN' cat
    docker-compose\($\|['`"*,)]\)
    PATTERN
    )"
    sed -i "s/${pattern}/docker compose\1/g" -- $(git grep -l "$pattern")
    sed -i 's/"docker compose"/"docker", "compose"/g' $(git grep -Fl '"docker compose"')

* Remove version from compose files.

sed -i '/^version:/d' $(git grep -il '^version:' '*docker-compose*.y*ml')

* Include `--all` in docker-compose ps command.

This is necessary for the plugin version of docker compose to query
exited containers.

* Changelog entry

* Support docker compose fallback for older docker versions that do not
have the compose plugin

* Improve PUT /deliveryservice_request_comments id (#8071)

* Update actions/upload-artifact and actions/download-artifact to v4 (#8081)

Fixes message:
This request has been automatically failed because it uses a deprecated
version of `actions/upload-artifact: v2`. Learn more:
https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

* Update Postgres version to 13.16 (#8079)

* Use :atc-postgres-version: role in documentation

* Get postgres version from .env in Traffic Ops spec file

* Get POSTGRES_VERSION from .env in Dockerfiles and docker-compose files

* Update Postgres version to 13.16

* Update Trafficserver Alpine image to 9.2.4 (#7994)

* No substitution in the name

* Download ATS from the Apache archive

download.apache.org only contains currently-supported releases.

* Use Alpine main repo version 3.16 for adding package libexecinfo-dev

Alpine versions above 3.16 do not contain package libexecinfo-dev, which
ATS needs.

Alpine 3.19 still fails for unknown reasons, but Alpine 3.18 builds with
this fix.

* Set default for GITHUB_REPOSITORY

* Update Apache Traffic Server to 9.2.4

(cherry picked from commit 14007e3)

* Update Go version to 1.23.1 (#8073)

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>

(cherry picked from commit f647d58)

* Update Chromedriver Versions (#8084)

Update chromedriver

(cherry picked from commit 289c2c3)

* Update Go version to 1.22.5 (#8034)

* Update Go version to 1.22.5

* Update some images to Rocky Linux 8

---------

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>
Co-authored-by: Zach Hoffman <zrhoffman@apache.org>

(cherry picked from commit 0b21b43)

* Update changelog-1 and ciab.yml

* Update Go version to 1.23.1 (#8073)

Co-authored-by: asf-ci-trafficcontrol <asf-ci-trafficcontrol@users.noreply.github.com>

(cherry picked from commit f647d58)

---------

Co-authored-by: Zach Hoffman <zrhoffman@apache.org>
Co-authored-by: asf-ci-trafficcontrol <127552316+asf-ci-trafficcontrol@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants