New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[ZEPPELIN-5665] rework xml factory #4302

Merged

zjffdu merged 1 commit into apache:master from pjfanning:xml-factory

Mar 15, 2022

Contributor

pjfanning commented Mar 3, 2022

What is this PR for?

A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html

What type of PR is it?

[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]

Todos

- Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5665

How should this be tested?

Strongly recommended: add automated unit tests for any new or changed behavior
Outline any manual steps to test the PR here.

Screenshots (if appropriate)

Questions:

Does the licenses files need update?
Is there breaking changes for older versions?
Does this needs documentation?


          rework xml factory

e7e47f7

Contributor Author

pjfanning commented Mar 3, 2022

@jongyoul could you review this when you get a chance?

Contributor

zjffdu commented Mar 11, 2022

LGTM

zjffdu merged commit bea51d1 into apache:master

Member

jongyoul commented Mar 15, 2022

I've missed it. Thank you for merging it.

pjfanning deleted the xml-factory branch

March 17, 2022 09:14

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet